feat: add strike backend #186
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
im-adithya
force-pushed
the
feat/strike
branch
from
73f9991 to
25a35fe
Compare
im-adithya
force-pushed
the
feat/strike
branch
from
25a35fe to
bea0431
Compare
im-adithya
force-pushed
the
feat/strike
branch
from
8d072ee to
85fbfef
Compare
bumi
reviewed
Jan 4, 2024
| @@ -404,7 +404,7 @@ func (svc *AlbyOAuthService) ListTransactions(ctx context.Context, senderPubkey | |||
| endpoint += "/outgoing" | |||
| } | |||
|
|
|||
| requestUrl := fmt.Sprintf("%s%s?%s", svc.cfg.AlbyAPIURL, endpoint, urlParams.Encode()) | |||
| requestUrl := fmt.Sprintf("%s%s?%s", svc.cfg.OAuthAPIURL, endpoint, urlParams.Encode()) | |||
There was a problem hiding this comment.
careful this would break the current deployment.
can you take care that the deployment is properly configured.
There was a problem hiding this comment.
Will take care of it once this is merged 👍
|
We should drop this, since any update or change should be done from now on in https://github.com/getAlby/nwc.getalby.com/tree/feat/strike, since that one will be deployed on https://strike-nwc.albylabs.com/ |
|
I agree, closing for now CC @im-adithya |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for Strike as a backend for NWC.
Supports
get_balance,get_info,make_invoice,pay_invoiceTested using alby-js-sdk