-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Wails (v2) #217
Closed
Closed
Feat: Wails (v2) #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it possible to host a NWC instance on a public network with simple authentication
which is potentially smaller?
# By Roland Bewick (20) and others # Via GitHub (13) and others * main: (38 commits) chore: add dependabot feat: add support both internal and public relay URL fix: relay public url fix: expiresAt and maxAmount handling fix: app expiresAt handling fix: style for darkmode chore: correctly handle query parameters in new UI (WIP) chore: rename app name parameter (#154) fix: navbar padding on lg fix: ui cleanup no more default protocol-redirect (#107) ui improvements & layout simplification (#153) feat: nwc connection page ui (#151) chore: address migration feedback chore: format with prettier feat: run css scripts via npm chore: add human-readable name to migration ids feat: add manual migrations using gormigration fix: don't log resp id fix: convert expiresAt to int ... # Conflicts: # main.go
* feature/breez-backend: (38 commits) chore: add dependabot feat: add support both internal and public relay URL fix: relay public url fix: expiresAt and maxAmount handling fix: app expiresAt handling fix: style for darkmode chore: correctly handle query parameters in new UI (WIP) chore: rename app name parameter (#154) fix: navbar padding on lg fix: ui cleanup no more default protocol-redirect (#107) ui improvements & layout simplification (#153) feat: nwc connection page ui (#151) chore: address migration feedback chore: format with prettier feat: run css scripts via npm chore: add human-readable name to migration ids feat: add manual migrations using gormigration fix: don't log resp id fix: convert expiresAt to int ...
# By Roland Bewick (28) and others # Via GitHub (8) and others * main: (51 commits) fix: only set preimage on transaction if Alby invoice is settled fix: mark make_invoice expiry unsupported in alby LNClient chore: update invoice functions to match NIP-46 extensions spec chore: remove unnecessary env file fix: do not return failed LND payments in list_transactions fix: LND listTransactions fix: map alby transaction amount as millisats fix: map alby invoice to nip47 invoice chore: rename types and add TODOs fix: tests chore: comment out unused code chore: add list_transactions to NIP_47_CAPABILITIES fix: lnd keysend chore: also log preimage fix: keysend request permission method and convert millisats to sats fix: remove unnecessary permission creation in test chore: use pay_invoice permissions fix: timestamp in test chore: further changes and test chore: minor fixes ... # Conflicts: # service.go
feat: basic onboarding flow
otherwise the NWC payload is too big we need to add pagination later
Argon2 key derivation
Feat: reconnect to relay
Feat: unlock screen (WIP)
# Conflicts: # .github/workflows/workflow.yaml
Moved to getAlby#1 |
rolznz
added a commit
to getAlby/nostr-wallet-connect-next
that referenced
this pull request
Jul 8, 2024
Breaking change: - Wails app default directory is now `albyhub`, not `alby-nwc` - Wails mac filename is `albyhub` not `AlbyHub` just to be consistent everywhere - ~~Wails app executable is now `albyhub`, not `Nostr-Wallet-Connect`~~ _EDIT: we override the output filename in the action, so no change_ Other changes: - RPI links go to getalby.com zero links instead of this repository
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows NWC to be run in multiple formats:
The LN backend can be initialized after startup, allowing the user to choose and configure their node.
THIS IS NOT BACKWARD COMPATIBLE. POSTGRES IS BEING REMOVED, SQLITE REQUIRES A FRESH DB.
Post-merge: update Github to point at master branch
TODOs:
handle requests made before LNClient starts up - should return an error code if svc.lnClient is nil - @im-adithya - cannot be doneTo move to seperate issues: