Fix #534 by implementing name validating widget #543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@davidlatwe That's great work! :) Lovely. 🚀 Also code looks clean. I wonder however if it should include the reported message (the invalid characters) somewhere on the Widget too so the user is aware of that aside of the "red fade" on the QLineEdit. What do you think? Or would it be overkill? |
|
Thanks @BigRoy :D Yeah, I agree that it would be better if we put a message printer in the bottom of that dialog. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
This fixes #534, not only invalid character will be blocked in GUI, invalid input from pasting will be cleaned for better UX.
But since Creator App also shares the same widget, it has changed, too.