Make DittoService ditto instance optional to fix retain issue #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DittoService strong reference to Ditto instance caused ForgeSwift library crash when
reinitializing. This commit fixes the issue by making the ditto instance optional and
implementing cleanup.
- DittoService:
- create new optional private ditto shadow property
- expose force-unwrapped accessor of shadow property
- implement cleanup function to set instance to nil
- DataManager:
- add cleanup function to ReplicatingDataInterface protocol
- add cleanup pass-through function
- implement cleanup pass-through functions in ChatUI, and ChatCore
ErikEverson
approved these changes
Feb 10, 2025
There was a problem hiding this comment.
This would be good to investigate more because if we null out DittoChat or DittoChatUI the references should go away so we should not need this to clean it up.
I will approve for now to get the fix in but I would like to reverse this when we have more time to get to the bottom of this issues
|
going with #40 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DittoService strong reference to Ditto instance caused ForgeSwift library crash when reinitializing. This commit fixes the issue by making the ditto instance optional and implementing cleanup.