-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add: ability to select collection that live-query is scoped to, default is null/all #21
Conversation
|
e4809af
to
815d9af
Compare
815d9af
to
b565888
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, going to go back and check out the kafka chart change before approving
cool yeah the kafka change was I had set some values as examples but as soon as you set |
I see your edit from 4 days ago that added and then the leak. LGTM |
Current version of chart just makes all live-query deployments query all collections this change allows the user to configure this.
Also there were some unexpected values that leaked through values in the kafka chart that were fixed this upgrades to that version.