Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add: ability to select collection that live-query is scoped to, default is null/all #21

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

ChrisMcKenzie
Copy link
Contributor

@ChrisMcKenzie ChrisMcKenzie commented Jan 15, 2025

Current version of chart just makes all live-query deployments query all collections this change allows the user to configure this.

Also there were some unexpected values that leaked through values in the kafka chart that were fixed this upgrades to that version.

@ChrisMcKenzie ChrisMcKenzie changed the title add: ability to select collection that live-query is scoped to, defau… add: ability to select collection that live-query is scoped to, default is null/all Jan 15, 2025
Copy link

github-actions bot commented Jan 15, 2025

Linting charts...

------------------------------------------------------------------------------------------------------------------------
 Charts to be processed:
------------------------------------------------------------------------------------------------------------------------
 big-peer => (version: "0.2.15", path: "charts/big-peer")
------------------------------------------------------------------------------------------------------------------------

Hang tight while we grab the latest from your chart repositories...
...Successfully got an update from the "ditto-helm-charts" chart repository
...Successfully got an update from the "kafka" chart repository
...Successfully got an update from the "cert-manager" chart repository
Update Complete. ⎈Happy Helming!⎈
Saving 11 charts
Downloading hades from repo oci://quay.io/ditto-external
Downloading hydra-consul from repo oci://quay.io/ditto-external
Downloading hydra-store from repo oci://quay.io/ditto-external
Downloading hydra-subscription from repo oci://quay.io/ditto-external
Downloading service-token-validator from repo oci://quay.io/ditto-external
Downloading cert-manager from repo https://charts.jetstack.io
Downloading strimzi-kafka-operator from repo https://strimzi.io/charts
Downloading kafka from repo https://getditto.github.io/helm-charts/
Downloading dummy-auth-webhook from repo oci://quay.io/ditto-external
Downloading live-query-resource-controller from repo oci://quay.io/ditto-external
Already downloaded kafka from repo https://getditto.github.io/helm-charts/
Deleting outdated charts
Pulled: quay.io/ditto-external/hades:1.39.2-4b6e4e
Digest: sha256:76e0e2964e2c9c020130e9a46088d42c747ca7aa6c2d15070a9376714d35398c
Pulled: quay.io/ditto-external/hydra-consul:0.1.0
Digest: sha256:005ad2258b567529431f0f1068e772c080d4304d4b17b82b4611a208fa307470
Pulled: quay.io/ditto-external/hydra-store:1.39.2-4b6e4e
Digest: sha256:86d0b9f82e7163e3da9ae8d106fdbd6bccd345f3f7a30795cab8d2b4f874d14a
Pulled: quay.io/ditto-external/hydra-subscription:1.39.2-4b6e4e
Digest: sha256:3dff65b37c06cf774035c5f6f0d3b376315aebbebe2c914fd86c6774a28d9478
Pulled: quay.io/ditto-external/service-token-validator:0.2.1
Digest: sha256:b15467fd632e78eaea9ff5f73a166e89651933ca8af1efb1f7d6fead1d588fc5
Pulled: quay.io/ditto-external/dummy-auth-webhook:0.1.1
Digest: sha256:973a3eccc6da58e053c81b4c0cfd18d7bbb56b495ac5d7cf2145ce1ba2393ae4
Pulled: quay.io/ditto-external/live-query-resource-controller:0.1.0-002c59
Digest: sha256:8adce154435fc637537c9179c106a6f680a3fb57b04933595bf0ff44c1b0be30
Linting chart "big-peer => (version: \"0.2.15\", path: \"charts/big-peer\")"
Checking chart "big-peer => (version: \"0.2.15\", path: \"charts/big-peer\")" for a version bump...
Old chart version: 0.2.14
New chart version: 0.2.15
Chart version ok.
Validating /__w/helm-charts/helm-charts/charts/big-peer/Chart.yaml...
Validation success! 👍

### Chart [ big-peer ] charts/big-peer


Charts:      1 passed, 1 total
Test Suites: 0 passed, 0 total
Tests:       0 passed, 0 total
Snapshot:    0 passed, 0 total
Time:        23.591559ms

==> Linting charts/big-peer
[INFO] Chart.yaml: icon is recommended

1 chart(s) linted, 0 chart(s) failed

------------------------------------------------------------------------------------------------------------------------
 ✔︎ big-peer => (version: "0.2.15", path: "charts/big-peer")
------------------------------------------------------------------------------------------------------------------------
All charts linted successfully

@ChrisMcKenzie ChrisMcKenzie force-pushed the add/collection-option-lqt branch 4 times, most recently from e4809af to 815d9af Compare January 15, 2025 15:24
@ChrisMcKenzie ChrisMcKenzie force-pushed the add/collection-option-lqt branch from 815d9af to b565888 Compare January 15, 2025 16:29
Copy link
Contributor

@sjbodzo sjbodzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, going to go back and check out the kafka chart change before approving

@ChrisMcKenzie
Copy link
Contributor Author

LGTM, going to go back and check out the kafka chart change before approving

cool yeah the kafka change was I had set some values as examples but as soon as you set enabled: true for the externalListener it dumps like ingresses and annotations into the environment that aren't useful so I opted to comment that section so you can see the example but it doesn't leak out.

@sjbodzo
Copy link
Contributor

sjbodzo commented Jan 15, 2025

I see your edit from 4 days ago that added and then the leak. LGTM

@ChrisMcKenzie ChrisMcKenzie merged commit d57c8e6 into main Jan 15, 2025
1 check passed
@sjbodzo sjbodzo self-requested a review January 15, 2025 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants