AssemblyLoader will now scan the deps file to find and load all assemblies referencing the lib at startup #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arp lib, even if they aren't initially loaded as a dependent of the primary app Signed-off-by: Martin Pekurny <[email protected]>
…o it Signed-off-by: Martin Pekurny <[email protected]>
Signed-off-by: Martin Pekurny <[email protected]>
|
I see the problem with the failing tests. I will have a fix up as soon as I can. |
Signed-off-by: Martin Pekurny <[email protected]>
Signed-off-by: Martin Pekurny <[email protected]>
sriv
approved these changes
Dec 16, 2024
|
@mpekurny Thank you for contributing to gauge-dotnet. Your pull request has been labeled as a release candidate 🎉🎉. Merging this PR will trigger a release. Please bump up the version as part of this PR.Instructions to bump the version can found at CONTRIBUTING.md If the CONTRIBUTING.md file does not exist or does not include instructions about bumping up the version, please looks previous commits in git history to see what changes need to be done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
C# assembly loading is a lazy load strategy. When it loads the main assembly for an app, it loads only those assemblies it will need right away and then will load others as it needs them. Unfortunately, that means if your assembly includes another assembly that has steps which are only found through reflection, the second assembly may not be loaded right away and the initial scan will miss those step implementations causing your tests to fail. This change will attempt to read the deps file in the output directory, find all assemblies that have steps or hooks, and force them to load on startup. If the reading of the deps file fails, it will fall back on the old functionality of only loading the main app assembly.