Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PyPi release #2464

Merged
merged 1 commit into from
Feb 14, 2024
Merged

Fix PyPi release #2464

merged 1 commit into from
Feb 14, 2024

Conversation

chadlwilson
Copy link
Contributor

@chadlwilson chadlwilson commented Feb 10, 2024

PyPi now requires use of API tokens (and 2FA for the user that generates them). https://blog.pypi.org/posts/2024-01-01-2fa-enforced/

Steps needed

  • log in and generate an API token
  • Add GitHub secret for PYPI_API_TOKEN with the token

Copy link
Contributor

github-actions bot commented Feb 10, 2024

Benchmark Results

java_gradle_multithreaded.csv

Commit CPU Memory Time ExitCode
62b9937 10% 120752 0:23.40 0
b55b734 10% 108120 0:23.65 0
6475093 9% 114264 0:23.61 0
237a4b4 9% 113180 0:22.92 0

java_maven_serial.csv

Commit CPU Memory Time ExitCode
62b9937 80% 269976 0:17.24 0
b55b734 84% 216004 0:16.96 0
6475093 83% 260176 0:17.12 0
237a4b4 80% 260296 0:17.87 0

java_simple_multithreaded.csv

Commit CPU Memory Time ExitCode
62b9937 36% 70008 0:09.92 0
b55b734 38% 67900 0:09.27 0
6475093 30% 68364 0:12.14 0
237a4b4 23% 68548 0:14.44 0

java_gradle_serial.csv

Commit CPU Memory Time ExitCode
62b9937 9% 106932 0:24.90 0
b55b734 9% 118740 0:25.15 0
6475093 9% 117392 0:25.12 0
237a4b4 9% 105972 0:25.59 0

java_simple_parallel.csv

Commit CPU Memory Time ExitCode
62b9937 21% 72096 0:25.94 0
b55b734 24% 72212 0:22.78 0
6475093 22% 72064 0:23.98 0
237a4b4 21% 74480 0:25.07 0

java_gradle_parallel.csv

Commit CPU Memory Time ExitCode
62b9937 6% 119752 0:41.56 0
b55b734 5% 115740 0:40.07 0
6475093 5% 116668 0:46.13 0
237a4b4 5% 103620 0:44.38 0

java_maven_parallel.csv

Commit CPU Memory Time ExitCode
62b9937 41% 246160 0:33.10 0
b55b734 43% 231220 0:31.14 0
6475093 44% 243516 0:29.99 0
237a4b4 42% 227552 0:33.07 0

java_simple_serial.csv

Commit CPU Memory Time ExitCode
62b9937 42% 65868 0:14.17 0
b55b734 52% 66024 0:11.35 0
6475093 51% 65716 0:11.90 0
237a4b4 39% 69608 0:15.86 0

java_maven_multithreaded.csv

Commit CPU Memory Time ExitCode
62b9937 77% 234160 0:14.59 0
b55b734 67% 234752 0:16.79 0
6475093 58% 202856 0:19.71 0
237a4b4 74% 233148 0:15.36 0

Notes

  • The results above are generated by running against seed projects in https://github.com/getgauge/gauge-benchmark
  • These results are not persisted, but on merging to master the benchmark will be rerun.
  • These benchmark are run in Github Actions' agents, which are virtualized. Results are not to be taken as actual benchmarks.Rather, these are indicative numbers and make sense for comparison.

See Workflow log for more details.

@gaugebot
Copy link

gaugebot bot commented Feb 10, 2024

@chadlwilson Thank you for contributing to gauge. Your pull request has been labeled as a release candidate 🎉🎉.

Merging this PR will trigger a release.

Please bump up the version as part of this PR.

Instructions to bump the version can found at CONTRIBUTING.md

If the CONTRIBUTING.md file does not exist or does not include instructions about bumping up the version, please looks previous commits in git history to see what changes need to be done.

@chadlwilson
Copy link
Contributor Author

chadlwilson commented Feb 13, 2024

Validated the approach and twine config w/ API token via this run of the gauge-python plugin --> https://pypi.org/project/getgauge/

So this should be fine for next release.

@chadlwilson chadlwilson marked this pull request as ready for review February 13, 2024 14:13
@chadlwilson chadlwilson enabled auto-merge (squash) February 13, 2024 14:15
@chadlwilson
Copy link
Contributor Author

chadlwilson commented Feb 13, 2024

@sriv This can be merged any time, for use whenever the next release is.

@chadlwilson chadlwilson requested a review from sriv February 13, 2024 16:17
@chadlwilson chadlwilson disabled auto-merge February 14, 2024 02:05
@chadlwilson chadlwilson merged commit 851e878 into getgauge:master Feb 14, 2024
28 checks passed
@chadlwilson chadlwilson deleted the fix-pypi branch February 14, 2024 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant