Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form\Value: Move data methods to Data classes #6782

Merged

Conversation

distantnative
Copy link
Member

@distantnative distantnative commented Nov 5, 2024

  • Data::decode() has new $fail parameter. When set to false, method will return empty array instead of throwing exception.
  • Json::encode() has new $pretty parameter
  • Removed all Form\Mixin\Value methods that just encode/decode data

@distantnative distantnative self-assigned this Nov 5, 2024
src/Data/Data.php Outdated Show resolved Hide resolved
@distantnative distantnative marked this pull request as ready for review November 5, 2024 17:50
Copy link
Member

@bastianallgeier bastianallgeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it :)

@bastianallgeier bastianallgeier merged commit af35c8b into v5/changes/forms-cleanup-3 Nov 9, 2024
11 checks passed
@bastianallgeier bastianallgeier deleted the v5/changes/forms-data-methods branch November 9, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants