Add the latest version of a translation automatically #6791
Conversation
| $this->assertContentFileExists('en', $latest->id()); | ||
| $this->assertContentFileDoesNotExist('en', $changes->id()); | ||
| $this->assertContentFileExists('de', $latest->id()); | ||
| $this->assertContentFileExists('de', $changes->id()); |
There was a problem hiding this comment.
Comment: I don't want to block this PR because of it, but we should really try to get away from unit tests checking for the content file going forward as those are exactly the ones really biting us when we try to implement ImmutableMemoryStorage etc.
There was a problem hiding this comment.
That's the opposite of what @lukasbestle suggested. His thoughts were that we try to keep the dependencies in tests as low-level as possible. Checking for changes in the file system directly will make sure that we don't use version code or storage code in tests to prepare or check version and storage code.
There was a problem hiding this comment.
I can just tell you that so many unit tests issues were because of this when I tried to make the LabPage branch work. Because in many cases the storage type could change and then pinning unit tests to checking for a content file that is only used by one storage type blows up the setup.
There was a problem hiding this comment.
Yeah, I get it. I feel a bit lost here to be honest. I don't know a good way forward. Maybe some form of abstraction?
There was a problem hiding this comment.
I don't think we need to solve this here. Only midterm. But I would've thought that storage is exactly that abstraction.
Description
If the latest version of a translation does not exist yet when creating changes, the latest version of the default language is automatically copied over.
Ready?
For review team