Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail tests if error is logged #1045

Open
matthew-white opened this issue Oct 29, 2024 · 0 comments
Open

Fail tests if error is logged #1045

matthew-white opened this issue Oct 29, 2024 · 0 comments
Assignees
Labels
dx Developer workflow, automated checks testing Integration tests, unit tests

Comments

@matthew-white
Copy link
Member

Right now, tests as a whole fail if anything logs a warning. We've seen cases where a test manages to pass despite Vue logging a warning about something important that needs to be addressed, which is why this check is in place. This issue is to make it so that tests fail if anything logs an error as well.

One place this comes up specifically is with mockHttp(). If a test sends a request without using mockHttp(), that will log an error. However, at the moment, that doesn't lead to tests actually failing. It's easy to miss this error being logged.

@matthew-white matthew-white added the testing Integration tests, unit tests label Oct 29, 2024
@matthew-white matthew-white self-assigned this Oct 29, 2024
@github-project-automation github-project-automation bot moved this to 🕒 backlog in ODK Central Oct 29, 2024
@matthew-white matthew-white added the dx Developer workflow, automated checks label Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dx Developer workflow, automated checks testing Integration tests, unit tests
Projects
Status: 🕒 backlog
Development

No branches or pull requests

1 participant