Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dev:oidc npm script #1036

Closed
wants to merge 3 commits into from
Closed

Fix dev:oidc npm script #1036

wants to merge 3 commits into from

Conversation

alxndrsn
Copy link
Contributor

@alxndrsn alxndrsn commented Oct 15, 2024 •
edited
Loading

  • generate public/client-config.js at foreman startup
  • remove nginx's special handling for client-config.js

Closes #1034

alxndrsn added 3 commits October 15, 2024 09:55
Procfile: run nginx via docker
3f0dcd7 
This should help to standardise the nginx version running on different dev machines.

Closes getodk#1033
Use host network to allow proxying
4b132f5
Fix dev:oidc npm script
213baf6 
* generate public/client-config.js at foreman startup
* remove nginx's special handling for client-config.js
@alxndrsn alxndrsn marked this pull request as draft October 15, 2024 10:15
@alxndrsn
Copy link
Contributor Author

Relevant if #1035 is accepted.

@alxndrsn
Copy link
Contributor Author

#1034 not recreatable, so this change is not required.

@alxndrsn alxndrsn closed this Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

npm run dev:oidc broken
1 participant
@alxndrsn