fixes #756: don't make the odata request when route is being changed

src/composables/query-ref.js

@@ -65,7 +65,11 @@ export default ({ fromQuery, toQuery }) => {
   the same -- something we want to avoid.
   */
   let ignoreNextRouteChange = false;
-  watch(router.currentRoute, ({ query: newQuery }, { query: oldQuery }) => {
+  watch(router.currentRoute, ({ query: newQuery, name: oldRouteName }, { query: oldQuery, name: newRouteName }) => {
+    // If route is different then we don't need to set value from the query, it
+    // will be set during setup phase
+    if (oldRouteName !== newRouteName) return;
+
     if (ignoreNextRouteChange) {
       ignoreNextRouteChange = false;
       return;

test/components/submission/filters.spec.js

@@ -462,4 +462,23 @@ describe('SubmissionFilters', () => {
       });
     });
   });
+
+  it('should not send Submission OData request on navigating to another route after filter', () => {
+    testData.extendedForms.createPast(1);
+
+    return loadComponent('reviewState=%27approved%27')
+      .beforeEachResponse((_, { url }) => {
+        if (url.includes('.svc')) {
+          const filter = relativeUrl(url).searchParams.get('$filter');
+          filter.should.equal("(__system/reviewState eq 'approved')");
+        }
+      })
+      .afterResponses(component => {
+        const filters = component.getComponent(SubmissionFilters).props();
+        filters.reviewState.should.eql(["'approved'"]);
+      })
+      .complete()
+      .route('/projects/1/forms/f/draft/testing')
+      .testNoRequest();
+  });
 });

test/composables/query-ref.spec.js

@@ -44,6 +44,21 @@ describe('useQueryRef()', () => {
     result.value.should.equal('c,d');
   });
 
+  it('should not changes value of ref after a change of route name', async () => {
+    let result;
+    return load('/?x=a&y=b')
+      .afterResponses(app => {
+        result = withSetup(() => useQueryRef(options.comma), {
+          container: app.vm.$container
+        });
+        result.value.should.equal('a,b');
+      })
+      .load('/users?x=c&y=d')
+      .afterResponses(() => {
+        result.value.should.equal('a,b');
+      });
+  });
+
   describe('change to an irrelevant query parameter', () => {
     it('does not change the value of the ref', async () => {
       // `z` is the irrelevant query parameter that the ref doesn't use.