Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using Pinia in development temporarily #789

Merged
merged 1 commit into from
May 14, 2023
Merged

Conversation

matthew-white
Copy link
Member

@matthew-white matthew-white commented May 9, 2023

We use Pinia in development only, not production or testing. Pinia is helpful in development because it integrates with Vue devtools and provides nice logging. However, I'm running into an issue with Pinia that's affecting my work on #774: see #787. At some point, I'll want to fix that issue for real. However, for now I'm just going to turn off Pinia in development.

What has been done to verify that this works as intended?

#787 is only an issue in development. When I make this change, I no longer see it in development (entity.data becomes reactive).

Why is this the best possible solution? Were any other approaches considered?

I could remove more code related to Pinia from the file or comment it out, instead of using a constant condition in a ternary. However, since I intend to revert this PR at some point, I think it should be as small as possible. As before, webpack should remove Pinia from the production bundle.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

This change is not user-facing.

Does this change require updates to user documentation? If so, please file an issue here and include the link below.

No changes needed.

Before submitting this PR, please make sure you have:

  • run npm run test and npm run lint and confirmed all checks still pass OR confirm CircleCI build passes
  • verified that any code or assets from external sources are properly credited in comments or that everything is internally sourced

@matthew-white matthew-white requested a review from ktuite May 9, 2023 19:38
@matthew-white matthew-white merged commit 0da6ffc into master May 14, 2023
@matthew-white matthew-white deleted the temp-no-pinia branch May 14, 2023 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants