Stop using Pinia in development temporarily #789
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use Pinia in development only, not production or testing. Pinia is helpful in development because it integrates with Vue devtools and provides nice logging. However, I'm running into an issue with Pinia that's affecting my work on #774: see #787. At some point, I'll want to fix that issue for real. However, for now I'm just going to turn off Pinia in development.
What has been done to verify that this works as intended?
#787 is only an issue in development. When I make this change, I no longer see it in development (
entity.data
becomes reactive).Why is this the best possible solution? Were any other approaches considered?
I could remove more code related to Pinia from the file or comment it out, instead of using a constant condition in a ternary. However, since I intend to revert this PR at some point, I think it should be as small as possible. As before, webpack should remove Pinia from the production bundle.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
This change is not user-facing.
Does this change require updates to user documentation? If so, please file an issue here and include the link below.
No changes needed.
Before submitting this PR, please make sure you have:
npm run test
andnpm run lint
and confirmed all checks still pass OR confirm CircleCI build passes