Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lint: switch to using eslint directly #827

Merged
merged 7 commits into from
May 9, 2024
Merged

lint: switch to using eslint directly #827

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
cc1c97d
lint: switch to using eslint directly
Jul 12, 2023
0f29461
Demonstrate failures
Sep 6, 2023
b5e023e
Revert "Demonstrate failures"
Sep 6, 2023
9e2ac79
Merge branch 'master' into faster-lint
matthew-white May 9, 2024
5da6c50
Reinstall yorkie
matthew-white May 9, 2024
ca68902
Update lint scripts
matthew-white May 9, 2024
b8a26e9
Remove lintOnSave from config
matthew-white May 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,3 +30,5 @@ npm-debug.log*

/.nginx/*
!/.nginx/.gitkeep

/.eslintcache
190 changes: 2 additions & 188 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@
"dev": "nf start",
"dev:oidc": "VUE_APP_OIDC_ENABLED=true npm run dev",
"build": "vue-cli-service build",
"lint": "vue-cli-service lint --no-fix --max-warnings 0 src/ bin/ test/ *.js",
"lint:fix": "vue-cli-service lint --fix --max-warnings 0 src/ bin/ test/ *.js",
"lint": "eslint --max-warnings 0 --cache --ext .js,.vue src/ bin/ test/ *.js",
"lint:fix": "eslint --max-warnings 0 --fix --cache --ext .js,.vue src/ bin/ test/ *.js",
"test": "./test/run.sh"
},
"volta": {
Expand Down Expand Up @@ -38,7 +38,6 @@
},
"devDependencies": {
"@intlify/vue-i18n-loader": "~4",
"@vue/cli-plugin-eslint": "^5.0.8",
"@vue/cli-service": "^5.0.8",
"@vue/compiler-sfc": "~3",
"@vue/eslint-config-airbnb": "^7.0.0",
Expand All @@ -62,7 +61,8 @@
"should": "~13.2",
"sinon": "~9",
"util": "^0.12.5",
"vue-cli-plugin-i18n": "~2"
"vue-cli-plugin-i18n": "~2",
"yorkie": "^2.0.0"
},
"engines": {
"node": "20",
Expand Down
1 change: 0 additions & 1 deletion vue.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ module.exports = {
css: { url: false }
}
},
lintOnSave: false,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks to be an option of the ESLint plugin for Vue CLI, so I think we can remove it. From https://cli.vuejs.org/core-plugins/eslint.html#configuration:

The following option is under the section of vue.config.js. It is respected only when @vue/cli-plugin-eslint is installed.

pluginOptions: {
i18n: {
locale: 'en',
Expand Down