Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update dependencies, add job to test older pydantic #100

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

lindsay-stevens
Copy link
Contributor

@lindsay-stevens lindsay-stevens commented Nov 1, 2024

  • pydantic dependency assumes latest version in the range.
    • added actions job tests with the lower bound as well.
    • probably most likely package to cause conflicts for users e.g. relax pinned version of pydantic #94
    • requests not tested this way because often its releases are for security patches.
      • e.g. 2.32.0 and 2.32.1 were yanked for security reasons
  • includes formatting changes via ruff update

What has been done to verify that this works as intended?

Ran tests locally and GitHub actions CI

Why is this the best possible solution? Were any other approaches considered?

As mentioned above

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

Updates dependencies to latest versions

Do we need any specific form for testing your changes? If so, please attach one.

No

Does this change require updates to documentation? If so, please file an issue here and include the link below.

Before submitting this PR, please make sure you have:

  • included test cases for core behavior and edge cases in tests
  • run python -m unittest and verified all tests pass
  • run ruff format pyodk tests and ruff check pyodk tests to lint code
  • verified that any code or assets from external sources are properly credited in comments

@lindsay-stevens lindsay-stevens force-pushed the pyodk-deps branch 3 times, most recently from dcfc513 to 601f7f4 Compare November 1, 2024 11:20
- pydantic dependency assumes latest version in the range.
  - added actions job tests with the lower bound as well.
  - probably most likely package to cause conflicts for users.
  - requests not tested this way because often its releases
    are for security patches.
    - e.g. 2.32.0 and 2.32.1 were yanked for security reasons
- includes formatting changes via ruff update
@lognaturel lognaturel merged commit b09fe11 into getodk:master Nov 1, 2024
5 checks passed
@lindsay-stevens lindsay-stevens deleted the pyodk-deps branch November 2, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants