UploadFileForm: filter uploadable files to Excel spreadsheets #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -18,7 +18,7 @@ | |||
| DJANGO_TMP_HOME = os.environ['DJANGO_TMP_HOME'] | |||
|
|
|||
| class UploadFileForm(forms.Form): | |||
| file = forms.FileField() | |||
| file = forms.FileField(attrs={ 'accept': '.xls, .xlsx' }) | |||
There was a problem hiding this comment.
You made this change to Central, and I've been a fan! However, when I checked this out locally, I saw an error:
File "xlsform-online/xlsform_app/views.py", line 21, in UploadFileForm
file = forms.FileField(attrs={ 'accept': '.xls, .xlsx' })
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/site-packages/django/forms/fields.py", line 562, in __init__
super().__init__(**kwargs)
TypeError: Field.__init__() got an unexpected keyword argument 'attrs'
I did a quick search, but I don't see an extremely simple option along these lines. Possibly you pass a FileInput as a widget to the FileField and specify accept on the FileInput?
There was a problem hiding this comment.
Thanks for testing! It would be great to be able to run this project locally. 👋 #30
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Untested.
This change should filter files shown in the native file picker so that only
.xlsand.xlsxfiles are visible. This might be a usability improvement.