Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Deserialize SentryException #4791

Merged

Conversation

philipphofmann
Copy link
Member

Add Decodable/Deserializing of SentryException.

This PR is based on #4724.

#skip-changelog

Copy link

github-actions bot commented Feb 4, 2025

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against d76b1a1

Add Decodable/Deserializing of SentryException.
@philipphofmann philipphofmann force-pushed the feat/deserializing-sentry-exception branch from 13428c4 to 2890581 Compare February 4, 2025 08:19
@philipphofmann philipphofmann mentioned this pull request Feb 4, 2025
7 tasks
Copy link

codecov bot commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (feat/deserializing-events@cb1cefe). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@                      Coverage Diff                      @@
##             feat/deserializing-events     #4791   +/-   ##
=============================================================
  Coverage                             ?   91.561%           
=============================================================
  Files                                ?       646           
  Lines                                ?     75856           
  Branches                             ?     27389           
=============================================================
  Hits                                 ?     69455           
  Misses                               ?      6305           
  Partials                             ?        96           
Files with missing lines Coverage Δ
...wift/Protocol/Codable/SentryExceptionCodable.swift 100.000% <100.000%> (ø)
...ts/SentryTests/Protocol/SentryExceptionTests.swift 100.000% <100.000%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb1cefe...d76b1a1. Read the comment docs.

Copy link

github-actions bot commented Feb 4, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1233.82 ms 1245.48 ms 11.66 ms
Size 22.31 KiB 805.86 KiB 783.55 KiB

Baseline results on branch: feat/deserializing-events

Startup times

Revision Plain With Sentry Diff
242b57f 1236.13 ms 1252.17 ms 16.04 ms
74e111a 1229.31 ms 1244.63 ms 15.33 ms
378d4bd 1216.53 ms 1241.19 ms 24.66 ms
04e8394 1223.24 ms 1244.33 ms 21.08 ms
4dc265c 1221.31 ms 1238.55 ms 17.24 ms
8a562cc 1228.57 ms 1245.18 ms 16.60 ms
8dae1f6 1212.60 ms 1226.52 ms 13.93 ms

App size

Revision Plain With Sentry Diff
242b57f 22.31 KiB 801.48 KiB 779.17 KiB
74e111a 22.31 KiB 800.12 KiB 777.80 KiB
378d4bd 22.31 KiB 784.05 KiB 761.73 KiB
04e8394 22.31 KiB 771.93 KiB 749.62 KiB
4dc265c 22.31 KiB 798.21 KiB 775.90 KiB
8a562cc 22.31 KiB 773.33 KiB 751.02 KiB
8dae1f6 22.31 KiB 772.51 KiB 750.20 KiB

Copy link
Contributor

@philprime philprime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@philipphofmann philipphofmann merged commit 8067173 into feat/deserializing-events Feb 4, 2025
43 checks passed
@philipphofmann philipphofmann deleted the feat/deserializing-sentry-exception branch February 4, 2025 08:51
@philipphofmann philipphofmann self-assigned this Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants