Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v9]: Replace custom Platform & PlatformChecker with package platform #2729

Draft
wants to merge 3 commits into
base: v9
Choose a base branch
from

fixes

b80690d
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Draft

[v9]: Replace custom Platform & PlatformChecker with package platform #2729

fixes
b80690d
Select commit
Loading
Failed to load commit list.
GitHub Actions / Analysis of sentry_drift succeeded Feb 18, 2025 in 55s

Package analysis results for sentry_drift

Score

90/160 points
(56.25%)

Details

Follow Dart file conventions (30/30)

✔ 10/10 points: Provide a valid pubspec.yaml

✔ 5/5 points: Provide a valid README.md

✔ 5/5 points: Provide a valid CHANGELOG.md

✔ 10/10 points: Use an OSI-approved license

Detected license: MIT.

Provide documentation (20/20)

✔ 10/10 points: 20% or more of the public API has dartdoc comments

12 out of 14 API elements (85.7 %) have documentation comments.

Some symbols that are missing documentation: sentry_drift, sentry_drift.SentryQueryInterceptor.spanHelper.

✔ 10/10 points: Package has an example

Platform support (20/20)

✔ 20/20 points: Supports 6 of 6 possible platforms (iOS, Android, Web, Windows, macOS, Linux)

  • ✓ Android

  • ✓ iOS

  • ✓ Windows

  • ✓ Linux

  • ✓ macOS

  • ✓ Web

❌ 0/0 points: WASM compatibility

Unable to detect compatibility with runtime wasm, and this package will not be rewarded full points in a future version of the scoring model.

See https://dart.dev/web/wasm for details.

Pass static analysis (0/50)

❌ 0/50 points: code has no errors, warnings, lints, or formatting issues

Found 16 issues. Showing the first 2:

ERROR: The getter 'autoDbDriftQueryInterceptor' isn't defined for the type 'SentryTraceOrigins'.

lib/src/sentry_query_interceptor.dart:30:26

   ╷
30 │       SentryTraceOrigins.autoDbDriftQueryInterceptor,
   │                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^
   ╵

To reproduce make sure you are using the lints_core and run flutter analyze lib/src/sentry_query_interceptor.dart

ERROR: Undefined name 'SentrySpanDescriptions'.

lib/src/sentry_query_interceptor.dart:61:7

   ╷
61 │       SentrySpanDescriptions.dbOpen(dbName: _dbName),
   │       ^^^^^^^^^^^^^^^^^^^^^^
   ╵

To reproduce make sure you are using the lints_core and run flutter analyze lib/src/sentry_query_interceptor.dart

Support up-to-date dependencies (20/40)

✔ 10/10 points: All of the package dependencies are supported in the latest version

Package Constraint Compatible Latest
drift ^2.24.0 2.25.1 2.25.1
meta ^1.3.0 1.16.0 1.16.0
sentry 8.13.0 8.13.0 8.13.0
Transitive dependencies
Package Constraint Compatible Latest
async - 2.13.0 2.13.0
collection - 1.19.1 1.19.1
convert - 3.1.2 3.1.2
crypto - 3.0.6 3.0.6
ffi - 2.1.3 2.1.4
fixnum - 1.1.1 1.1.1
http - 1.3.0 1.3.0
http_parser - 4.1.2 4.1.2
path - 1.9.1 1.9.1
source_span - 1.10.1 1.10.1
sprintf - 7.0.0 7.0.0
sqlite3 - 2.7.4 2.7.4
stack_trace - 1.12.1 1.12.1
stream_channel - 2.1.4 2.1.4
string_scanner - 1.4.1 1.4.1
term_glyph - 1.2.2 1.2.2
typed_data - 1.4.0 1.4.0
uuid - 4.5.1 4.5.1
web - 1.1.0 1.1.0

To reproduce run dart pub outdated --no-dev-dependencies --up-to-date --no-dependency-overrides.

✔ 10/10 points: Package supports latest stable Dart and Flutter SDKs

❌ 0/20 points: Compatible with dependency constraint lower bounds

downgrade analysis failed failed with 16 errors:

  • UNDEFINED_GETTER - lib/src/sentry_query_interceptor.dart:30:26 - The getter 'autoDbDriftQueryInterceptor' isn't defined for the type 'SentryTraceOrigins'.
  • UNDEFINED_IDENTIFIER - lib/src/sentry_query_interceptor.dart:61:7 - Undefined name 'SentrySpanDescriptions'.
  • UNDEFINED_GETTER - lib/src/sentry_query_interceptor.dart:67:39 - The getter 'dbOpen' isn't defined for the type 'SentrySpanOperations'.

Run flutter pub downgrade and then flutter analyze to reproduce the above problem.

You may run dart pub upgrade --tighten to update your dependency constraints, see dart.dev/go/downgrade-testing for details.

Versions