Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove renderer from flutter_context #2751

Open
wants to merge 2 commits into
base: v9
Choose a base branch
from
Open

Remove renderer from flutter_context #2751

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
86013ff
v9: Remove renderer from `flutter_context`
denrase Feb 25, 2025
fc413a5
add cl entry
denrase Feb 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
- Responses are attached to the `Hint` object, which can be read in `beforeSend`/`beforeSendTransaction` callbacks via `hint.response`.
- For now, only the `dio` integration is supported.
- Enable privacy masking for screenshots by default ([#2728](https://github.com/getsentry/sentry-dart/pull/2728))
- Remove renderer from `flutter_context` ([#2751](https://github.com/getsentry/sentry-dart/pull/2751))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 🚫 The changelog entry seems to be part of an already released section ## 9.0.0.
    Consider moving the entry to the ## Unreleased section, please.


### Enhancements

Expand Down
3 changes: 0 additions & 3 deletions flutter/lib/src/event_processor/flutter_enricher_event_processor.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,8 +138,6 @@ class FlutterEnricherEventProcessor implements EventProcessor {
// ignore: deprecated_member_use
final hasRenderView = _widgetsBinding?.renderViewElement != null;

final renderer = _options.rendererWrapper.getRenderer()?.name;

return <String, String>{
'has_render_view': hasRenderView.toString(),
if (tempDebugBrightnessOverride != null)
Expand All @@ -156,7 +154,6 @@ class FlutterEnricherEventProcessor implements EventProcessor {
// Also always fails in tests.
// See https://github.com/flutter/flutter/issues/83919
// 'window_is_visible': _window.viewConfiguration.visible,
if (renderer != null) 'renderer': renderer,
if (appFlavor != null) 'appFlavor': appFlavor!,
};
}
Expand Down
2 changes: 1 addition & 1 deletion flutter/lib/src/view_hierarchy/view_hierarchy_integration.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import '../../sentry_flutter.dart';
import 'view_hierarchy_event_processor.dart';

/// A [Integration] that renders an ASCII represention of the entire view
/// A [Integration] that renders an ASCII representation of the entire view
/// hierarchy of the application when an error happens and includes it as an
/// attachment to the [Hint].
class SentryViewHierarchyIntegration
Expand Down
1 change: 0 additions & 1 deletion flutter/test/event_processor/flutter_enricher_event_processor_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,6 @@ void main() {
final flutterContext = event?.contexts['flutter_context'];
expect(flutterContext, isNotNull);
expect(flutterContext, isA<Map<String, String>>());
expect(flutterContext['renderer'], isNotNull);
});

testWidgets('accessibility context', (WidgetTester tester) async {
Expand Down
Loading