Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Screenshot Grouping #2754

Open
wants to merge 3 commits into
base: v9
Choose a base branch
from
Open

Screenshot Grouping #2754

wants to merge 3 commits into from

Conversation

denrase
Copy link
Collaborator

@denrase denrase commented Feb 25, 2025

📜 Description

  • Group screenshot related options in SentryFlutterOptions

💡 Motivation and Context

Closes #2633

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

Copy link

codecov bot commented Feb 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.66%. Comparing base (bb29ef9) to head (8f529d0).

Additional details and impacted files
@@            Coverage Diff             @@
##               v9    #2754      +/-   ##
==========================================
+ Coverage   88.49%   89.66%   +1.17%     
==========================================
  Files         262       91     -171     
  Lines        8750     2952    -5798     
==========================================
- Hits         7743     2647    -5096     
+ Misses       1007      305     -702     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -23,7 +23,11 @@
- Responses are attached to the `Hint` object, which can be read in `beforeSend`/`beforeSendTransaction` callbacks via `hint.response`.
- For now, only the `dio` integration is supported.
- Enable privacy masking for screenshots by default ([#2728](https://github.com/getsentry/sentry-dart/pull/2728))

- Screenshot Grouping ([#2754](https://github.com/getsentry/sentry-dart/pull/2754))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 🚫 The changelog entry seems to be part of an already released section ## 9.0.0.
    Consider moving the entry to the ## Unreleased section, please.

@denrase denrase marked this pull request as ready for review February 25, 2025 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant