Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(python-sdk): reformat config options #12607

Merged
merged 2 commits into from
Feb 6, 2025

Conversation

stephanie-anderson
Copy link
Contributor

  • make options more readable
  • add some of the missing options (documented others)
  • added argument types and default values

Copy link

vercel bot commented Feb 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
develop-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 6, 2025 3:44pm
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 6, 2025 3:44pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview Feb 6, 2025 3:44pm

Copy link

codecov bot commented Feb 6, 2025

Bundle Report

Changes will increase total bundle size by 428 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 10.7MB 168 bytes (0.0%) ⬆️
sentry-docs-client-array-push 9.39MB 260 bytes (0.0%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.63MB -0.0%
../instrumentation.js -3 bytes 965.23kB -0.0%
9523.js -3 bytes 941.45kB -0.0%
../app/[[...path]]/page.js 231 bytes 529.65kB 0.04%
../app/[[...path]]/page.js.nft.json -18 bytes 376.04kB -0.0%
../app/platform-redirect/page.js.nft.json -18 bytes 375.95kB -0.0%
../app/sitemap.xml/route.js.nft.json -18 bytes 373.92kB -0.0%

Files in ../app/[[...path]]/page.js:

  • ./src/components/sdkOption/style.module.scss → Total Size: 214 bytes

  • ./src/components/sdkOption/index.tsx → Total Size: 9.3kB

App Routes Affected:

App Route Size Change Total Size Change (%)
/[[...path]] 231 bytes 3.08MB 0.01%
view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 866.04kB -0.0%
static/css/*.css 144 bytes 22.91kB 0.63%
static/chunks/9557-*.js -3 bytes 391.11kB -0.0%
static/chunks/app/[[...path]]/page-*.js 122 bytes 72.53kB 0.17%
static/KAwNzBjI8aRHnOHFsyVYN/_buildManifest.js (New) 578 bytes 578 bytes 100.0% 🚀
static/KAwNzBjI8aRHnOHFsyVYN/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/J3ezccmiJTOPGX2f_qN9g/_buildManifest.js (Deleted) -578 bytes 0 bytes -100.0% 🗑️
static/J3ezccmiJTOPGX2f_qN9g/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️

Files in static/chunks/app/[[...path]]/page-*.js:

  • ./src/components/sdkOption/style.module.scss → Total Size: 232 bytes

Copy link
Contributor

@sentrivana sentrivana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome!

Left some suggestions to add/expand on some of the types

@stephanie-anderson stephanie-anderson merged commit abe2f92 into master Feb 6, 2025
13 checks passed
@stephanie-anderson stephanie-anderson deleted the python-config-options branch February 6, 2025 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants