Catch transport errors when flushing session (#439)

CHANGELOG.md

@@ -2,6 +2,10 @@
 
 ## Unreleased
 
+## 3.0.5
+
+- fix: Issue where transport errors can prevent app exit
+
 ## 3.0.4
 
 - fix: Use esModuleInterop for deepmerge (#432)
@@ -26,7 +30,9 @@
 A large refactor and simplification of the SDK moving most of the functionality into integrations used with
 `@sentry/browser` and `@sentry/node`.
 
-- Session tracking data sent by default. See our [release health docs for more details](https://docs.sentry.io/product/releases/health/). You can opt out of this behaviour by setting `autoSessionTracking: false` during SDK initialization.
+- Session tracking data sent by default. See our
+  [release health docs for more details](https://docs.sentry.io/product/releases/health/). You can opt out of this
+  behaviour by setting `autoSessionTracking: false` during SDK initialization.
 - Performance monitoring of renderer instances using the `BrowserTracing` integration from `@sentry/tracing`
 - Preload script no longer required [for most scenarios](https://github.com/getsentry/sentry-electron/issues/376)
 - Optional relative imports for main/renderer/preload entry points to help with bundlers

src/main/integrations/main-process-session.ts

@@ -44,10 +44,14 @@ export class MainProcessSession implements Integration {
     // Stop the exit so we have time to send the session
     event.preventDefault();
 
-    // End the session
-    await endSession();
+    try {
+      // End the session
+      await endSession();
+    } catch (e) {
+      // Ignore and log any errors which would prevent app exit
+      logger.log('[MainProcessSession] Error ending session', e);
+    }
 
-    // After flush we can safely exit
     app.exit();
   };
 }

src/main/transports/electron-offline-net.ts

@@ -38,7 +38,7 @@ export class ElectronOfflineNetTransport extends ElectronNetTransport {
         this._requestSuccess();
         return response;
       } catch (error) {
-        if (error instanceof HTTPError && error.status != 'rate_limit') {
+        if (error instanceof HTTPError && error.status !== 'rate_limit') {
           logger.log('Dropping request');
           // We don't queue HTTP errors that are not rate limited
           throw error;

test/e2e/server/index.ts

@@ -7,7 +7,7 @@ import { inspect } from 'util';
 import { eventIsSession } from '../recipe';
 import { createLogger } from '../utils';
 
-import { parse_multipart, sentryEventFromFormFields } from './multi-part';
+import { parseMultipart, sentryEventFromFormFields } from './multi-part';
 
 const log = createLogger('Test Server');
 
@@ -106,7 +106,7 @@ export class TestServer {
           return;
         }
 
-        const result = await parse_multipart(ctx);
+        const result = await parseMultipart(ctx);
         const [event, namespacedData] = sentryEventFromFormFields(result);
         const dumpFile = result.files.upload_file_minidump != undefined && result.files.upload_file_minidump > 1024;
 

test/e2e/server/multi-part.ts

@@ -13,7 +13,7 @@ export interface MultipartResult {
   files: { [key: string]: number };
 }
 
-export function parse_multipart(
+export function parseMultipart(
   ctx: Koa.ParameterizedContext<any, Router.IRouterParamContext<any, any>, any>,
 ): Promise<MultipartResult> {
   return new Promise((resolve) => {