feat: Update JavaScript SDKs to v7.90.0 #800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timfish
changed the title
timfish
force-pushed
the
feat/javascript-sdks
branch
from
441a3b8 to
75ac368
Compare
timfish
changed the title
lforst
approved these changes
Jan 2, 2024
| @@ -44,21 +44,26 @@ export class AdditionalContext implements Integration { | |||
| addGlobalEventProcessor(async (event: Event) => this._addAdditionalContext(event)); | |||
|
|
|||
| // Some metrics are only available after app ready so we lazily load them | |||
| void whenAppReady.then(() => { | |||
| const { language, screen } = this._options; | |||
| whenAppReady.then( | |||
There was a problem hiding this comment.
Just fyi, when you're 100% certain that a promise cannot reject it is also fine to just ignore the lint rule!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates to v7.90.0 of the JavaScript SDKs. The update to v7.91.0 will come in another PR since this requires changes for ANR and I'd like to keep that seperate.
ScopeDatarather than using privateScopeproperties