Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Migrate to functional integration APIs #808

Merged
merged 2 commits into from
Jan 4, 2024

Conversation

timfish
Copy link
Collaborator

@timfish timfish commented Jan 3, 2024

Migrates all the integrations to use the new functional style.

@timfish timfish marked this pull request as ready for review January 3, 2024 23:50
@timfish timfish requested a review from mydea January 4, 2024 10:29
Copy link
Member

@mydea mydea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just skimmed this TBH but overall looks good to me!

@timfish
Copy link
Collaborator Author

timfish commented Jan 4, 2024

We've got quite good e2e test coverage. I broke a couple in the process of this PR!

@timfish timfish merged commit 1453ec2 into getsentry:master Jan 4, 2024
32 checks passed
@timfish timfish deleted the feat/migrate-integration-apis branch January 4, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants