Skip to content

Commit

Permalink
fix(react): From location can be undefined in Tanstack Router Instrum…
Browse files Browse the repository at this point in the history
…entation (#15235)

fixes #15234

Due to a big bug in TanStack Router getting fixed, this needs an
optional chain to not die.
  • Loading branch information
tannerlinsley authored and Lms24 committed Jan 30, 2025
1 parent 36bdc47 commit 0a9c4d0
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion packages/react/src/tanstackrouter.ts
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ export function tanstackRouterBrowserTracingIntegration(
// The onBeforeNavigate hook is called at the very beginning of a navigation and is only called once per navigation, even when the user is redirected
castRouterInstance.subscribe('onBeforeNavigate', onBeforeNavigateArgs => {
// onBeforeNavigate is called during pageloads. We can avoid creating navigation spans by comparing the states of the to and from arguments.
if (onBeforeNavigateArgs.toLocation.state === onBeforeNavigateArgs.fromLocation.state) {
if (onBeforeNavigateArgs.toLocation.state === onBeforeNavigateArgs.fromLocation?.state) {
return;
}

Expand Down

0 comments on commit 0a9c4d0

Please sign in to comment.