Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(browser): Export ipAddress helpers for use in other SDKs #15079

Merged
merged 7 commits into from
Feb 3, 2025

Conversation

krystofwoldrich
Copy link
Member

@krystofwoldrich krystofwoldrich commented Jan 20, 2025

Copy link
Contributor

github-actions bot commented Jan 20, 2025

size-limit report 📦

Path Size % Change Change
@sentry/browser 22.94 KB +0.03% +5 B 🔺
@sentry/browser - with treeshaking flags 22.81 KB +0.03% +7 B 🔺
@sentry/browser (incl. Tracing) 35.78 KB -0.01% -2 B 🔽
@sentry/browser (incl. Tracing, Replay) 72.58 KB +0.02% +14 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 66.14 KB +0.04% +27 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas) 76.83 KB +0.01% +4 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback) 89.33 KB - -
@sentry/browser (incl. Feedback) 39.64 KB +0.02% +8 B 🔺
@sentry/browser (incl. sendFeedback) 27.57 KB -0.03% -8 B 🔽
@sentry/browser (incl. FeedbackAsync) 32.35 KB -0.01% -1 B 🔽
@sentry/react 24.78 KB +0.08% +19 B 🔺
@sentry/react (incl. Tracing) 37.67 KB +0.03% +9 B 🔺
@sentry/vue 27.1 KB -0.02% -5 B 🔽
@sentry/vue (incl. Tracing) 37.5 KB +0.02% +4 B 🔺
@sentry/svelte 23.07 KB +0.04% +8 B 🔺
CDN Bundle 24.25 KB +0.05% +12 B 🔺
CDN Bundle (incl. Tracing) 35.92 KB +0.02% +4 B 🔺
CDN Bundle (incl. Tracing, Replay) 70.56 KB +0.01% +3 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) 75.7 KB +0.02% +13 B 🔺
CDN Bundle - uncompressed 70.85 KB +0.04% +22 B 🔺
CDN Bundle (incl. Tracing) - uncompressed 106.59 KB +0.03% +22 B 🔺
CDN Bundle (incl. Tracing, Replay) - uncompressed 217.44 KB +0.01% +22 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 230.01 KB +0.01% +22 B 🔺
@sentry/nextjs (client) 38.64 KB +0.02% +4 B 🔺
@sentry/sveltekit (client) 36.29 KB +0.01% +3 B 🔺
@sentry/node 156.51 KB - -
@sentry/node - without tracing 97.56 KB - -
@sentry/aws-serverless 107.07 KB -0.01% -1 B 🔽

View base workflow run

Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume we need to backport this to the v8 branch? develop is against v9 atm.

@krystofwoldrich
Copy link
Member Author

krystofwoldrich commented Jan 20, 2025

Depends on the previous PR #15008 was that still merged into v8? Because the target was also develop.

I think https://github.com/getsentry/sentry-javascript/pull/15008 should be released in v8 and if so, then this PR #15079 should be too. So RN can use the hooks.

@AbhiPrasad
Copy link
Member

I think #15008 is a v9 only change (breaking behaviour change). @mydea no plans to change anything in v8 right?

we might have to just copy paste in the methods for RN for now, and then switch them out when RN updates to use v9.

@timfish
Copy link
Collaborator

timfish commented Jan 21, 2025

I think these utilities would be more helpful in @sentry/core because then they can be used in the Electron SDK!

@krystofwoldrich
Copy link
Member Author

If #15008 is breaking change for JS, it's for RN as well, so we will adopt this with v9.

@krystofwoldrich krystofwoldrich merged commit 3c4df06 into develop Feb 3, 2025
144 of 145 checks passed
@krystofwoldrich krystofwoldrich deleted the kw-export-ip-address-helpers branch February 3, 2025 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants