-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(flags): add Statsig browser integration #15319
Conversation
@@ -0,0 +1,15 @@ | |||
export type FeatureGate = { | |||
readonly name: string; | |||
readonly value: boolean; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excluded props:
// readonly ruleID: string;
// readonly details: EvaluationDetails;
// readonly __evaluation: GateEvaluation | null;
type EventNameToEventDataMap = { | ||
gate_evaluation: { gate: FeatureGate }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dev-packages/browser-integration-tests/suites/integrations/featureFlags/statsig/basic/test.ts
Outdated
Show resolved
Hide resolved
packages/browser/src/integrations/featureFlags/statsig/integration.ts
Outdated
Show resolved
Hide resolved
packages/browser/src/integrations/featureFlags/statsig/integration.ts
Outdated
Show resolved
Hide resolved
dev-packages/browser-integration-tests/suites/integrations/featureFlags/statsig/init.js
Outdated
Show resolved
Hide resolved
❌ 2 Tests Failed:
View the top 2 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does our unleash SDK have users? best practice would be to add featureFlagClient
arg to unleash integration and keep unleashClient
as optional but deprecated - then in a breaking release we can remove. But actually if it's only published in v9 branch it's probably fine to break it now (not in this PR).
It's released in v8 as well, I'm not sure how many users |
Ref https://develop.sentry.dev/sdk/expected-features/#feature-flags. Adds an integration for tracking Statsig js-client flag evaluations, specifically the
checkGate
method which is used for boolean release flags.Statsig references:
Our current FF integrations only support boolean flag values so "dynamic config", "experiments", and "layers" will not be tracked for now.
Closes https://github.com/getsentry/team-replay/issues/539