Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(browser): Avoid using example.com for browser-integration-tests #15332

Merged
merged 4 commits into from
Feb 7, 2025

Conversation

mydea
Copy link
Member

@mydea mydea commented Feb 6, 2025

Mostly we already add a route for this anyhow, but it can be confusing. So let's just use a proper non-existing URL there to ensure we notice issues earlier.

Mostly we already add a route for this anyhow, but it can be confusing. So let's just use a proper non-existing URL there to ensure we notice issues earlier.
@mydea mydea requested a review from Lms24 February 6, 2025 16:05
@mydea mydea self-assigned this Feb 6, 2025
@mydea mydea requested a review from a team as a code owner February 6, 2025 16:05
@sodabrew
Copy link

sodabrew commented Feb 7, 2025

So, let's just say someone notices this PR and registers the domain?

Please read RFC 2606 and RFC 6761 for non-registerable domains. tl;dr: sentry-test-site.example would work fine.

image

@mydea mydea merged commit 53194d7 into develop Feb 7, 2025
47 checks passed
@mydea mydea deleted the fn/fix-browserIntegrationTests branch February 7, 2025 11:59
@billyvg
Copy link
Member

billyvg commented Feb 7, 2025

Good callout @sodabrew, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants