Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix(node): Ensure httpIntegration propagates traces (#15233)" #15354

Merged
merged 2 commits into from
Feb 10, 2025

Conversation

lforst
Copy link
Member

@lforst lforst commented Feb 10, 2025

#15233 introduced bugs (e.g. #15316) via vendored code that should not be shipped at all as we don't know what else is impacted.

We are reverting the PR. If we re-introduce this we need to properly test the vendored code.

I verified that this is indeed fixing bugs by reverting the changelog dogfooding to 9.0.0-alpha.0.

@lforst lforst requested review from Lms24 and chargome February 10, 2025 09:36
Copy link
Contributor

github-actions bot commented Feb 10, 2025

size-limit report 📦

Path Size % Change Change
@sentry/browser 22.9 KB - -
@sentry/browser - with treeshaking flags 22.69 KB - -
@sentry/browser (incl. Tracing) 35.78 KB - -
@sentry/browser (incl. Tracing, Replay) 72.59 KB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 66.06 KB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 76.83 KB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 89.57 KB - -
@sentry/browser (incl. Feedback) 39.85 KB - -
@sentry/browser (incl. sendFeedback) 27.53 KB - -
@sentry/browser (incl. FeedbackAsync) 32.32 KB - -
@sentry/react 24.74 KB - -
@sentry/react (incl. Tracing) 37.67 KB - -
@sentry/vue 27.1 KB - -
@sentry/vue (incl. Tracing) 37.48 KB - -
@sentry/svelte 22.94 KB - -
CDN Bundle 24.13 KB - -
CDN Bundle (incl. Tracing) 35.85 KB - -
CDN Bundle (incl. Tracing, Replay) 70.49 KB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 75.63 KB - -
CDN Bundle - uncompressed 70.59 KB - -
CDN Bundle (incl. Tracing) - uncompressed 106.47 KB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 217.33 KB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 229.89 KB - -
@sentry/nextjs (client) 38.64 KB - -
@sentry/sveltekit (client) 36.21 KB - -
@sentry/node 156.35 KB -0.15% -235 B 🔽
@sentry/node - without tracing 97.33 KB -0.26% -252 B 🔽
@sentry/aws-serverless 106.84 KB -0.22% -234 B 🔽

View base workflow run

@lforst lforst merged commit 480fa2a into develop Feb 10, 2025
145 checks passed
@lforst lforst deleted the lforst-revert-15233 branch February 10, 2025 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants