Skip to content

Commit

Permalink
cleanup testing
Browse files Browse the repository at this point in the history
  • Loading branch information
billyvg committed Feb 27, 2025
1 parent 1f5f5c3 commit 05548de
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ type Bucket = [
];

const BUBBLE_SERIES_ID = '__release_bubble__';
const BUBBLE_AREA_SERIES_ID = '__release_bubble_area__';
const DEFAULT_BUBBLE_SIZE = 14;

// "padding" around the bubbles as it is drawn on canvas vs CSS, this may need
Expand Down Expand Up @@ -172,7 +173,7 @@ function createReleaseBubbleMouseListeners({
}

instance.setOption({
series: [{id: 'release-mark-area', markArea: {data: []}}],
series: [{id: BUBBLE_AREA_SERIES_ID, markArea: {data: []}}],
});
},
onMouseOver: (
Expand All @@ -186,7 +187,7 @@ function createReleaseBubbleMouseListeners({
instance.setOption({
series: [
{
id: 'release-mark-area',
id: BUBBLE_AREA_SERIES_ID,
type: 'custom',
renderItem: () => {},
markArea: {
Expand Down Expand Up @@ -431,7 +432,7 @@ export function useReleaseBubbles({
}: UseReleaseBubblesParams) {
const organization = useOrganization();
const {openDrawer} = useDrawer();
const hasReleaseBubbles = organization.features.includes('release-bubbles-ui') || true;
const hasReleaseBubbles = organization.features.includes('release-bubbles-ui');
const buckets =
(hasReleaseBubbles &&
releases?.length &&
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -126,8 +126,7 @@ export function TimeSeriesWidgetVisualization(props: TimeSeriesWidgetVisualizati
});

const hasReleaseBubbles =
(organization.features.includes('release-bubbles-ui') || true) &&
!props.showReleaseLines;
organization.features.includes('release-bubbles-ui') && !props.showReleaseLines;

const releaseSeries = props.releases
? hasReleaseBubbles
Expand Down

0 comments on commit 05548de

Please sign in to comment.