Skip to content

Commit

Permalink
fix(explore): update the confidence footer in explore to display the …
Browse files Browse the repository at this point in the history
…actual number of series returned in a groupby (#86056)

Updates the confidence footer in explore to display the actual number of
series returned in a groupby. Previously we always displayed 5 even when
we have < 5 series returned.
  • Loading branch information
edwardgou-sentry authored Feb 28, 2025
1 parent 705ae96 commit 1f728d6
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
4 changes: 3 additions & 1 deletion static/app/views/explore/charts/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -288,7 +288,9 @@ export function ExploreCharts({
<ConfidenceFooter
sampleCount={chartInfo.sampleCount}
confidence={chartInfo.confidence}
topEvents={topEvents}
topEvents={
topEvents ? Math.min(topEvents, chartInfo.data.length) : undefined
}
/>
)
}
Expand Down
3 changes: 3 additions & 0 deletions static/app/views/explore/hooks/useTopEvents.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,9 @@ import {Mode} from 'sentry/views/explore/contexts/pageParamsContext/mode';

export const TOP_EVENTS_LIMIT = 5;

// TODO: There's a limitation with this hook when a top n query < 5 series.
// This hook always returns 5, which can be misleading, but there's no simple way
// to get the series count without adding more complexity to this hook.
export function useTopEvents(): number | undefined {
const visualizes = useExploreVisualizes();
const groupBys = useExploreGroupBys();
Expand Down

0 comments on commit 1f728d6

Please sign in to comment.