Skip to content

Commit

Permalink
fix(uptime): Add heading and description to overview (#84756)
Browse files Browse the repository at this point in the history
  • Loading branch information
evanpurkhiser authored Feb 7, 2025
1 parent 1d38696 commit 5e5bf3f
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 2 deletions.
4 changes: 3 additions & 1 deletion static/app/views/insights/uptime/settings.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,9 @@ export const DATA_TYPE = t('Uptime Check');
export const DATA_TYPE_PLURAL = t('Uptime Checks');
export const BASE_URL = 'uptime';

export const MODULE_DESCRIPTION = t('Monitor availability of HTTP URLs.');
export const MODULE_DESCRIPTION = t(
'Uptime monitors continuously track configured URLs, delivering alerts and insights to quickly identify downtime and troubleshoot issues.'
);
export const MODULE_DOC_LINK = 'https://docs.sentry.io/product/alerts/uptime-monitoring/';

export const MODULE_FEATURES = ['uptime', 'insights-uptime'];
Expand Down
2 changes: 1 addition & 1 deletion static/app/views/insights/uptime/views/overview.spec.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ describe('Uptime Overview', function () {

await waitForElementToBeRemoved(() => screen.queryAllByTestId('loading-indicator'));

expect(screen.getByRole('heading', {level: 1})).toHaveTextContent('Backend');
expect(screen.getByRole('heading', {level: 1})).toHaveTextContent('Uptime Monitors');
const tab = screen.getByRole('tab', {name: 'Uptime Monitors'});
expect(tab).toBeInTheDocument();
expect(tab).toHaveAttribute('aria-selected', 'true');
Expand Down
11 changes: 11 additions & 0 deletions static/app/views/insights/uptime/views/overview.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import {EnvironmentPageFilter} from 'sentry/components/organizations/environment
import PageFilterBar from 'sentry/components/organizations/pageFilterBar';
import {normalizeDateTimeParams} from 'sentry/components/organizations/pageFilters/parse';
import {ProjectPageFilter} from 'sentry/components/organizations/projectPageFilter';
import {PageHeadingQuestionTooltip} from 'sentry/components/pageHeadingQuestionTooltip';
import Pagination from 'sentry/components/pagination';
import Panel from 'sentry/components/panels/panel';
import SearchBar from 'sentry/components/searchBar';
Expand All @@ -31,6 +32,7 @@ import {BackendHeader} from 'sentry/views/insights/pages/backend/backendPageHead
import {ModuleName} from 'sentry/views/insights/types';
import {OwnerFilter} from 'sentry/views/monitors/components/ownerFilter';

import {MODULE_DESCRIPTION, MODULE_DOC_LINK, MODULE_TITLE} from '../../uptime/settings';
import {OverviewTimeline} from '../components/overviewTimeline';

export default function UptimeOverview() {
Expand Down Expand Up @@ -84,6 +86,15 @@ export default function UptimeOverview() {
<ModulePageProviders moduleName="uptime" pageTitle={t('Overview')}>
<BackendHeader
module={ModuleName.UPTIME}
headerTitle={
<Fragment>
{MODULE_TITLE}
<PageHeadingQuestionTooltip
docsUrl={MODULE_DOC_LINK}
title={MODULE_DESCRIPTION}
/>
</Fragment>
}
headerActions={
<ButtonBar gap={1}>
<LinkButton
Expand Down

0 comments on commit 5e5bf3f

Please sign in to comment.