feat(nav-views): Enforce no deletion on last view (#85998)

[Last PR](#85959) failed because
that branch didn't have some tests that were in master. This PR fixes
the tests to expect the new param.

static/app/components/nav/issueViews/issueViewNavEllipsisMenu.spec.tsx

@@ -2,7 +2,10 @@ import {render, screen, userEvent, waitFor} from 'sentry-test/reactTestingLibrar
 
 import {IssueSortOptions} from 'sentry/views/issueList/utils';
 
-import {IssueViewNavEllipsisMenu} from './issueViewNavEllipsisMenu';
+import {
+  IssueViewNavEllipsisMenu,
+  type IssueViewNavEllipsisMenuProps,
+} from './issueViewNavEllipsisMenu';
 
 describe('IssueViewNavEllipsisMenu', () => {
   const mockView = {
@@ -23,13 +26,14 @@ describe('IssueViewNavEllipsisMenu', () => {
     label: 'Test View',
   };
 
-  const defaultProps = {
+  const defaultProps: IssueViewNavEllipsisMenuProps = {
     baseUrl: '/organizations/sentry/issues',
     deleteView: jest.fn(),
     duplicateView: jest.fn(),
     setIsEditing: jest.fn(),
     updateView: jest.fn(),
     view: mockView,
+    isLastView: false,
   };
 
   beforeEach(() => {
@@ -97,4 +101,10 @@ describe('IssueViewNavEllipsisMenu', () => {
       expect(screen.queryByText('Rename')).not.toBeInTheDocument();
     });
   });
+
+  it('disables delete button when isLastView is true', () => {
+    render(<IssueViewNavEllipsisMenu {...defaultProps} isLastView />);
+
+    expect(screen.queryByText('Delete')).not.toBeInTheDocument();
+  });
 });

static/app/components/nav/issueViews/issueViewNavEllipsisMenu.tsx

@@ -14,10 +14,11 @@ import {useNavigate} from 'sentry/utils/useNavigate';
 import useOrganization from 'sentry/utils/useOrganization';
 import type {IssueView} from 'sentry/views/issueList/issueViews/issueViews';
 
-interface IssueViewNavEllipsisMenuProps {
+export interface IssueViewNavEllipsisMenuProps {
   baseUrl: string;
   deleteView: () => void;
   duplicateView: () => void;
+  isLastView: boolean;
   setIsEditing: (isEditing: boolean) => void;
   updateView: (view: IssueView) => void;
   view: IssueView;
@@ -32,6 +33,7 @@ export function IssueViewNavEllipsisMenu({
   duplicateView,
   updateView,
   baseUrl,
+  isLastView,
 }: IssueViewNavEllipsisMenuProps) {
   const navigate = useNavigate();
   const organization = useOrganization();
@@ -127,6 +129,7 @@ export function IssueViewNavEllipsisMenu({
               label: t('Delete'),
               priority: 'danger',
               onAction: deleteView,
+              disabled: isLastView,
             },
           ],
         },

static/app/components/nav/issueViews/issueViewNavItemContent.tsx

@@ -42,6 +42,11 @@ export interface IssueViewNavItemContentProps {
    * Whether the item is active.
    */
   isActive: boolean;
+  /**
+   * Whether the item is the last view in the list.
+   * This will be removed once view sharing/starring is implemented.
+   */
+  isLastView: boolean;
   /**
    * A callback function that updates the view with new params.
    */
@@ -65,6 +70,7 @@ export function IssueViewNavItemContent({
   updateView,
   deleteView,
   duplicateView,
+  isLastView,
 }: IssueViewNavItemContentProps) {
   const organization = useOrganization();
   const location = useLocation();
@@ -137,6 +143,7 @@ export function IssueViewNavItemContent({
           >
             <IssueViewNavQueryCount view={view} />
             <IssueViewNavEllipsisMenu
+              isLastView={isLastView}
               setIsEditing={setIsEditing}
               view={view}
               updateView={updateView}

static/app/components/nav/issueViews/issueViewNavItems.tsx

@@ -228,6 +228,7 @@ export function IssueViewNavItems({
             updateView={updatedView => handleUpdateView(view, updatedView)}
             deleteView={() => handleDeleteView(view)}
             duplicateView={() => handleDuplicateView(view)}
+            isLastView={views.length === 1}
           />
         </AnimatePresence>
       ))}