Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(insights): Adds more no value rendering to more cells in web vitals sample table #84690

Merged
merged 2 commits into from
Feb 6, 2025

Conversation

edwardgou-sentry
Copy link
Contributor

Adds no value elements to more empty cells in the Web Vitals Page summary samples table to match existing no value columns.

@edwardgou-sentry edwardgou-sentry requested a review from a team as a code owner February 6, 2025 15:24
@edwardgou-sentry edwardgou-sentry requested a review from a team February 6, 2025 15:24
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Feb 6, 2025
Copy link
Member

@gggritso gggritso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, just one suggestion

Copy link

codecov bot commented Feb 6, 2025

Bundle Report

Changes will increase total bundle size by 12.37kB (0.04%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
app-webpack-bundle-array-push 33.2MB 12.37kB (0.04%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: app-webpack-bundle-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
chunks/app_actionCreators_discoverHomepageQueries_tsx-app_bootstrap_initializeApp_tsx-app_components-2ddc8c.*.js 64 bytes 1.38MB 0.0%
chunks/app_components_assigneeBadge_tsx-app_components_badge_featureBadge_tsx-app_components_charts_-eed9e1.*.js 1.69kB 1.14MB 0.15%
chunks/app_actionCreators_onboardingTasks_tsx-app_actionCreators_redirectToProject_tsx-app_actionCre-bc1371.*.js 138 bytes 453.39kB 0.03%
chunks/app_actionCreators_guides_tsx-app_actionCreators_preferences_tsx-app_components_avatar_actorA-95b65d.*.js 30 bytes 295.05kB 0.01%
chunks/app_views_dashboards_dashboard_tsx-app_views_metrics_constants_tsx-data_image_svg_xml_base64_-91a9a4.*.js 686 bytes 280.84kB 0.24%
entrypoints/app.js 84 bytes 98.71kB 0.09%
chunks/app_components_feedback_widget_us*kWidget_tsx-app_views_projectDetail_index_tsx.5176123a442b93b5f614.js (New) 94.64kB 94.64kB 100.0% 🚀
chunks/app_components_breadcrumbs_tsx-app_components_feedback_widget_us*kWidget_tsx-app_utils-df50cf.0f4d1f5fcc607d286cd4.js (New) 57.23kB 57.23kB 100.0% 🚀
chunks/app_utils_userselect_tsx-app_views_insights_browser_webVitals_views_pageOverview_tsx.*.js 90 bytes 52.22kB 0.17%
chunks/app_views_stories_index_tsx.*.js 221 bytes 41.04kB 0.54%
chunks/app_components_charts_eventsRequest_tsx-app_components_feedback_widget_us*kWidget_tsx--64a49b.241912fe9c468baa49b8.js (New) 37.82kB 37.82kB 100.0% 🚀
chunks/app_components_feedback_widget_us*kWidget_tsx-app_views_performance_transactionSummary-51d702.b63f8f67856d3acc0e06.js (New) 37.27kB 37.27kB 100.0% 🚀
chunks/app_views_performance_content_tsx-node_modules_echarts_lib_chart_scatter_js-node_modules_echa-942304.*.js 1 bytes 32.17kB 0.0%
chunks/app_components_feedback_widget_us*kWidget_tsx-app_views_insights_common_components_cha-d2aaf9.051589729b27cc38f289.js (New) 31.93kB 31.93kB 100.0% 🚀
chunks/app_components_feedback_widget_us*kWidget_tsx-app_components_performance_transactionSe-feae7d.32d1a653bad12b30f664.js (New) 24.18kB 24.18kB 100.0% 🚀
chunks/app_components_feedback_widget_us*kWidget_tsx-app_utils_discover_discoverQuery_tsx-app-c5fefe.803e05acd60f0c725069.js (New) 17.11kB 17.11kB 100.0% 🚀
chunks/app_components_feedback_widget_us*kWidget_tsx-app_components_gridEditable_sortLink_tsx-d372f4.db17009ba0c1cdd87a74.js (New) 16.21kB 16.21kB 100.0% 🚀
chunks/app_components_feedback_widget_us*kWidget_tsx-app_components_performance_transactionSe-f61270.a715d20f011273001ea2.js (New) 13.36kB 13.36kB 100.0% 🚀
chunks/app_components_charts_lineChart_tsx-app_components_feedback_widget_us*kWidget_tsx-app_-26fc43.9db38fcd219a2e211dac.js (New) 12.25kB 12.25kB 100.0% 🚀
chunks/app_actionCreators_prompts_tsx-app_components_feedback_widget_us*k_tsx-app_components_-5240c4.f27a5396d5715a71f910.js (New) 12.12kB 12.12kB 100.0% 🚀
chunks/app_components_workflowEngine_form_control_index_stories_tsx.*.js (New) 9.32kB 9.32kB 100.0% 🚀
chunks/app_views_organizationCreate_index_tsx.*.js 47 bytes 8.8kB 0.54%
chunks/app_components_feedback_widget_us*kWidget_tsx-app_views_projectDetail_index_tsx.c11736408e51a967ff19.js (Deleted) -94.64kB 0 bytes -100.0% 🗑️
chunks/app_components_breadcrumbs_tsx-app_components_feedback_widget_us*kWidget_tsx-app_utils-df50cf.cff4d445e9b2af6ec22c.js (Deleted) -57.23kB 0 bytes -100.0% 🗑️
chunks/app_components_charts_eventsRequest_tsx-app_components_feedback_widget_us*kWidget_tsx--64a49b.b5486f5b3bd6bd871f4e.js (Deleted) -37.82kB 0 bytes -100.0% 🗑️
chunks/app_components_feedback_widget_us*kWidget_tsx-app_views_performance_transactionSummary-51d702.d026bd3b367f320a3fe7.js (Deleted) -37.27kB 0 bytes -100.0% 🗑️
chunks/app_components_feedback_widget_us*kWidget_tsx-app_views_insights_common_components_cha-d2aaf9.13c5f6e7c7aab9044350.js (Deleted) -31.93kB 0 bytes -100.0% 🗑️
chunks/app_components_feedback_widget_us*kWidget_tsx-app_components_performance_transactionSe-feae7d.aaa56a2211bff6d93bb2.js (Deleted) -24.18kB 0 bytes -100.0% 🗑️
chunks/app_components_feedback_widget_us*kWidget_tsx-app_utils_discover_discoverQuery_tsx-app-c5fefe.fa8e7e4c0828bfd37d13.js (Deleted) -17.11kB 0 bytes -100.0% 🗑️
chunks/app_components_feedback_widget_us*kWidget_tsx-app_components_gridEditable_sortLink_tsx-d372f4.5304138b5ddba73911de.js (Deleted) -16.21kB 0 bytes -100.0% 🗑️
chunks/app_components_feedback_widget_us*kWidget_tsx-app_components_performance_transactionSe-f61270.677ce3c0813fece1c750.js (Deleted) -13.36kB 0 bytes -100.0% 🗑️
chunks/app_components_charts_lineChart_tsx-app_components_feedback_widget_us*kWidget_tsx-app_-26fc43.c1a5695fc53675aadf50.js (Deleted) -12.25kB 0 bytes -100.0% 🗑️
chunks/app_actionCreators_prompts_tsx-app_components_feedback_widget_us*k_tsx-app_components_-5240c4.c4e7459e2bbed2b2c0ac.js (Deleted) -12.12kB 0 bytes -100.0% 🗑️

@edwardgou-sentry edwardgou-sentry merged commit b685aef into master Feb 6, 2025
43 checks passed
@edwardgou-sentry edwardgou-sentry deleted the egou/fix/page-summary-tables-no-value branch February 6, 2025 17:12
@github-actions github-actions bot locked and limited conversation to collaborators Feb 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants