Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(explore): Update comparison view confidence footer to display proper number of series #86038

Conversation

edwardgou-sentry
Copy link
Contributor

Updates the confidence footer in the comparison view charts to display the correct number of top n series, instead of always displaying 5.
image

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Feb 27, 2025
@edwardgou-sentry edwardgou-sentry marked this pull request as ready for review February 27, 2025 17:34
@edwardgou-sentry edwardgou-sentry requested a review from a team as a code owner February 27, 2025 17:34
Copy link
Member

@shruthilayaj shruthilayaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make this change for explore charts too?

@edwardgou-sentry
Copy link
Contributor Author

Can we make this change for explore charts too?

I checked explore, and it looks like they're using a hook to determine top n count, so it doesn't have this issue.

@edwardgou-sentry edwardgou-sentry merged commit af67008 into master Feb 27, 2025
43 of 44 checks passed
@edwardgou-sentry edwardgou-sentry deleted the egou/fix/comparison-view-confidence-footer-group-by-count branch February 27, 2025 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants