Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(explore): update the confidence footer in explore to display the actual number of series returned in a groupby #86056

Merged
merged 1 commit into from
Feb 28, 2025
Merged

fix(explore): update the confidence footer in explore to display the actual number of series returned in a groupby #86056

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion static/app/views/explore/charts/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,7 +288,9 @@ export function ExploreCharts({
<ConfidenceFooter
sampleCount={chartInfo.sampleCount}
confidence={chartInfo.confidence}
topEvents={topEvents}
topEvents={
topEvents ? Math.min(topEvents, chartInfo.data.length) : undefined
}
/>
)
}
Expand Down
3 changes: 3 additions & 0 deletions static/app/views/explore/hooks/useTopEvents.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,9 @@ import {Mode} from 'sentry/views/explore/contexts/pageParamsContext/mode';

export const TOP_EVENTS_LIMIT = 5;

// TODO: There's a limitation with this hook when a top n query < 5 series.
// This hook always returns 5, which can be misleading, but there's no simple way
// to get the series count without adding more complexity to this hook.
export function useTopEvents(): number | undefined {
const visualizes = useExploreVisualizes();
const groupBys = useExploreGroupBys();
Expand Down
Loading