Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(replay): Add a tooltip to the Replay List page Error column #86133

Merged
merged 2 commits into from
Mar 3, 2025
Merged

feat(replay): Add a tooltip to the Replay List page Error column #86133

merged 2 commits into from
Mar 3, 2025
+21 −1

Conversation

ryan953
Copy link
Member

@ryan953 ryan953 commented Feb 28, 2025 •
edited
Loading

SCR-20250303-htgw

Fixes #86195

@ryan953 ryan953 requested a review from a team as a code owner February 28, 2025 20:27
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Feb 28, 2025
aliu39
aliu39 approved these changes Feb 28, 2025
View reviewed changes
Copy link
Member

@aliu39 aliu39 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could maybe add a link to "inbound filters"?

@ryan953 ryan953 merged commit 98cc59a into master Mar 3, 2025
44 checks passed
@ryan953 ryan953 deleted the ryan953/replay-list-error-count-tooltip branch March 3, 2025 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aliu39 aliu39 aliu39 approved these changes

Assignees
No one assigned
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Replay Index] Add tooltip copy to Errors column to clarify error count calculation
2 participants
@ryan953 @aliu39