feat(view-sharing): Double write position to new table in PUT endpoint #86153
+76
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
MichaelSun48
commented
Feb 28, 2025
Comment on lines
+186
to
+193
| starred_views = GroupSearchViewStarred.objects.filter( | ||
| organization=self.organization, user_id=self.user.id | ||
| ) | ||
| assert len(starred_views) == len(response.data) | ||
| for idx, view in enumerate(response.data): | ||
| assert starred_views[idx].position == idx | ||
| assert starred_views[idx].position == view["position"] | ||
| assert str(starred_views[idx].group_search_view.id) == view["id"] |
There was a problem hiding this comment.
I just augmented the old tests to ensure the new entries were being created.
Double checking for both the enumeration index and view position (lines 191-192) is a little unnecessary, but just a sanity check.
malwilley
reviewed
Feb 28, 2025
malwilley
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
PUT/group-search-views/endpoint to double write the positions parameter to the new table created in this PR. This is necessary to ensure the tables stay in sync before backfilling.