Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(insights): remove performance-landing-page-stats-period flag #86199

Merged
merged 3 commits into from
Mar 3, 2025

Conversation

DominikB2014
Copy link
Contributor

Just doing a bit of cleanup. This feature has been GA almost 2 years now, no need to keep the flag and it's conditions around.

@DominikB2014 DominikB2014 requested review from a team as code owners March 3, 2025 16:35
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Mar 3, 2025
Copy link

codecov bot commented Mar 3, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
9628 1 9627 4
View the top 1 failed test(s) by shortest run time
Performance > Landing > Index renders all transactions view
Stack Traces | 0.632s run time
Error: expect(jest.fn()).toHaveBeenNthCalledWith(n, ...expected)

n: 1
Expected: Anything, ObjectContaining {"query": ObjectContaining {"environment": [], "interval": "1h", "partial": "1", "project": [], "query": "event.type:transaction", "referrer": "api.performance.generic-widget-chart.user-misery-area", "statsPeriod": "14d", "yAxis": ["user_misery()", "tpm()", "failure_rate()"]}}
Received: ".../organizations/org-slug/events-stats/", {"error": [Function error], "query": {"environment": [], "interval": "1h", "partial": "1", "project": [], "query": "event.type:transaction", "referrer": "api.performance.generic-widget-chart.user-misery-area", "statsPeriod": "28d", "yAxis": ["user_misery()", "tpm()", "failure_rate()"]}, "success": [Function success]}

Number of calls: 1
    at Object.<anonymous> (.../performance/landing/index.spec.tsx:204:28)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@DominikB2014 DominikB2014 merged commit 78b77cf into master Mar 3, 2025
42 checks passed
@DominikB2014 DominikB2014 deleted the DominikB2014/flag-removal branch March 3, 2025 19:41
DominikB2014 added a commit that referenced this pull request Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants