-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve: Only load async workers if deps available #89
Open
jylamont
wants to merge
1
commit into
master
Choose a base branch
from
02-21-improve_only_load_async_workers_if_deps_available
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
improve: Only load async workers if deps available #89
jylamont
wants to merge
1
commit into
master
from
02-21-improve_only_load_async_workers_if_deps_available
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 24, 2025
Merged
Merged
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Feb 24, 2025
Merged
Merged
3acabf6
to
eaac98d
Compare
89cf450
to
fe85416
Compare
eaac98d
to
5ee246b
Compare
fe85416
to
801ef51
Compare
5ee246b
to
38eb412
Compare
0c3a807
to
6405f8e
Compare
13ff379
to
4b753e0
Compare
6405f8e
to
feca23f
Compare
9d5158f
to
913e239
Compare
feca23f
to
56dea5f
Compare
913e239
to
f340488
Compare
56dea5f
to
f5b98f5
Compare
This was referenced Feb 24, 2025
f340488
to
db57f51
Compare
f5b98f5
to
a722f66
Compare
db57f51
to
bac9ac2
Compare
a722f66
to
cf891bb
Compare
bac9ac2
to
488e0ad
Compare
cf891bb
to
0df5db5
Compare
488e0ad
to
f8f4c2f
Compare
d3a290c
to
d01b0a9
Compare
f8f4c2f
to
605307f
Compare
d01b0a9
to
5cc0b0c
Compare
5cc0b0c
to
f873ff0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
lib/vero/workers/resque_worker.rb:9
- The removal of the options.transform_keys call in ResqueWorker may affect the expected key format. Please verify that Vero::Senders::Base.new.call handles options consistently without requiring symbolized keys.
Vero::Senders::Base.new.call(api_class, domain, options)
lib/vero.rb:29
- Since the SuckerPunchWorker has been relocated from lib/vero/sucker_punch_worker.rb to lib/vero/workers/sucker_punch_worker.rb, please confirm that the ignore path is correct and matches the new file structure.
loader.ignore("#{__dir__}/vero/workers/sucker_punch_worker") unless defined?(SuckerPunch)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to further insulate queue workers implementations if your app doesn't have this dependency. Zeitwerk will only load the code if a constant like
Sidekiq
is defined.