This repository has been archived by the owner on Dec 17, 2024. It is now read-only.
Merge ACL whitelist #123
Merged
Merge ACL whitelist #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tuommaki
reviewed
Mar 6, 2024
| @@ -535,6 +535,14 @@ impl Database { | |||
| Ok(()) | |||
| } | |||
|
|
|||
| pub async fn get_acl_whitelist(&self) -> Result<Vec<entity::PublicKey>> { | |||
| let dbkey_set: Vec<entity::PublicKey> = sqlx::query("SELECT 1 FROM acl_whitelist") | |||
There was a problem hiding this comment.
Did you test this? This query returns literal 1 for each row that exists in the DB. I'd expect this to yield error when trying to parse as public key?
There was a problem hiding this comment.
Yes, I copy and paste from another query. I thought the 1 was interpreted as a prepared statement, the first return field. I didn't test the read in fact because I start only one time.
I correct and to a read test.
There was a problem hiding this comment.
I've to add a test too, when the public key parse fail.
There was a problem hiding this comment.
I've corrected the query and added the test.
tuommaki
approved these changes
Mar 7, 2024
Co-authored-by: Tuomas Mäkinen <[email protected]>
|
Done I merge |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I let the code in the network module. Not sure where to put it.
I define the merge function alone so that I can test it without the db and network.
I put some rules about the merge: