Skip to content
This repository has been archived by the owner on Dec 17, 2024. It is now read-only.

Set vmid txhash link #124

Merged
merged 4 commits into from
Mar 7, 2024
Merged

Set vmid txhash link #124

merged 4 commits into from
Mar 7, 2024

Conversation

musitdev
Copy link
Contributor

@musitdev musitdev commented Mar 6, 2024

Most, I change to use Tx Hash to link task/Tx and Vm execution.
I remove VMId when it wasn't necessary for the logic.
I didn't touch the resource part.

I do a local test and the Txs execute correctly.

@musitdev musitdev requested a review from tuommaki March 6, 2024 17:43
Copy link
Contributor

@tuommaki tuommaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

I also tested this with e2e test & taiko-demo. Both succeeded 👌

@musitdev musitdev merged commit 855554f into main Mar 7, 2024
4 checks passed
@musitdev musitdev deleted the set_vmid_txhash_link branch March 7, 2024 09:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants