Skip to content
This repository has been archived by the owner on Dec 17, 2024. It is now read-only.

Persist tx execution state #44

Merged
merged 5 commits into from
Jan 21, 2024
Merged

Persist tx execution state #44

merged 5 commits into from
Jan 21, 2024

Conversation

tuommaki
Copy link
Contributor

In order to avoid re-executing old transactions on every restart, maintain execution state.

Gevulot devnet is permissioned due to its nature. For this need,
implement basic transaction authorization based on authors' public keys.
In order to avoid re-executing old transactions on every restart,
maintain execution state.
@tuommaki tuommaki self-assigned this Jan 21, 2024
@tuommaki tuommaki requested a review from musitdev January 21, 2024 16:44
Copy link
Contributor

@musitdev musitdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that propagated and executed are not really part of the Tx, but a more state that indicate at what stage they are in their processing pipeline. For that type-state programming works well in Rust.
It's another thing that we'll discuss when thing will be more calm.

@tuommaki
Copy link
Contributor Author

I think that propagated and executed are not really part of the Tx, but a more state that indicate at what stage they are in their processing pipeline. For that type-state programming works well in Rust.
It's another thing that we'll discuss when thing will be more calm.

💯

I totally agree with you. As soon as we get this thing in the air, let's refactor this into better direction.

Base automatically changed from tx-authorization to proto January 21, 2024 17:28
@tuommaki tuommaki merged commit c4ea88a into proto Jan 21, 2024
4 checks passed
@tuommaki tuommaki deleted the tx-exec-status branch January 21, 2024 17:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants