This repository has been archived by the owner on Dec 17, 2024. It is now read-only.
Tx file propagation #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tuommaki
reviewed
Jan 24, 2024
crates/cli/localkey.pki
Outdated
There was a problem hiding this comment.
I'd maybe drop this from the repo & add a .gitignore entry for localkey.pki or *.pki.
There was a problem hiding this comment.
Yes good idea I add it. I didn't see I've added it.
| #[arg( | ||
| long, | ||
| long_help = "", | ||
| env = "GEVULOT_P2P_DISCOVERY_ADDR", | ||
| default_value = "34.88.251.176:9999" | ||
| )] | ||
| #[arg(long, long_help = "", env = "GEVULOT_P2P_DISCOVERY_ADDR")] |
There was a problem hiding this comment.
Why drop the default value?
There was a problem hiding this comment.
To manage the case the node start without connecting, sort of primary bootstraper. In this case, you specify nothing and the node didn't try to connect.
|
Folding all PRs for operator onboarding 🙂 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Deploy Tx prover and image file propagation among all nodes.
Does a Run Tx can contain a download file? I'm not sure, it works in this case because of the path. The download manager server its file from the image directory.
I correct an issue with the Tx propagation. The Tx wasn't processed the same way if it came from RPC or p2p. The correction is hard coded to avoid to add another Mutex.