This repository has been archived by the owner on Dec 17, 2024. It is now read-only.
Rename node binary's key generation command #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`gevulot generate node-key` -> `gevulot generate key` The `node-key` command still exists, but will be phased out. The new command name allows for more ubiquitous use of gevulot container e.g. in prover/verifier development purposes.
tuommaki
requested review from
musitdev,
teempai,
kylegranger and
vadasnorbert
|
Going with this at light speed. Shout me if you disagree with this and we'll revert. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gevulot generate node-key->gevulot generate keyThe
node-keycommand still exists, but will be phased out. The new command name allows for more ubiquitous use of gevulot container e.g. in prover/verifier development purposes.NOTE: I added bunch of you as reviewers just to make you aware of this change 🙂