Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server : correct signal handler #11795

Merged
merged 1 commit into from
Feb 10, 2025
Merged

server : correct signal handler #11795

merged 1 commit into from
Feb 10, 2025

Conversation

ngxson
Copy link
Collaborator

@ngxson ngxson commented Feb 10, 2025

Supersede #11731

Tested in 2 cases:

  1. When the server is idle (not processing any requests), ctrl+C calls clean_up() then exit gracefully
  2. When is server is busy processing a request, ctrl+C stops the server_queue, calls clean_up() then exit gracefully

NOTE: This is NOT intended to fix ggml-org/llama.vim#35 as the issue may not come from llama-server, potentially machine-specific config - need more info on the issue.

@ngxson ngxson requested a review from ggerganov February 10, 2025 15:54
@ngxson ngxson merged commit 0893e01 into master Feb 10, 2025
46 checks passed
@ngxson ngxson mentioned this pull request Feb 10, 2025
Closed
tinglou pushed a commit to tinglou/llama.cpp that referenced this pull request Feb 13, 2025
@ngxson @tinglou
server : correct signal handler (ggerganov#11795)
10b9dc6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggerganov ggerganov ggerganov approved these changes

Assignees
No one assigned
Labels
examples server
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

once started, the server can't be shut down using ctrl-c or ctrl-d
2 participants
@ngxson @ggerganov