Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ability to auto start a cmd (e.g. llama-server) with vscode #15

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

emcodem
Copy link

@emcodem emcodem commented Jan 27, 2025

Added a config item llama-vscode.launch_cmd that accepts a full cmd line as written in the shell/cmd prompt.
The Cmd is started on plugin activation and restarted whenever the launch_cmd config changes
When the Cmd exits, there is a toast message stating exit code and stderr

@ggerganov ggerganov requested a review from Copilot January 29, 2025 11:34

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • package.json: Language not supported
Comments suppressed due to low confidence (2)

src/llama-server.ts:81

  • The launch command should be validated to ensure it is not an empty string before being used.
const launchCmd = this.extConfig.launch_cmd;

src/architect.ts:51

  • [nitpick] The error message could be more user-friendly. Suggestion: The llama-vscode launch command process has closed with exit code ${data.code}. Error: ${data.stderr}.
vscode.window.showErrorMessage(`llama-vscode launchCmd Process closed, code: ${data.code}, stderr: ${data.stderr}`);
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant