Skip to content

Commit

Permalink
Add shadow DOM support (hardkoded#1994)
Browse files Browse the repository at this point in the history
  • Loading branch information
kblok authored Jul 18, 2022
1 parent a12f106 commit faec0b1
Show file tree
Hide file tree
Showing 3 changed files with 163 additions and 2 deletions.
2 changes: 1 addition & 1 deletion appveyor/GenerateDocs.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ if($env:APPVEYOR_REPO_TAG -eq 'True' -And $env:framework -eq 'net6.0' -And $env:

git config --global user.email "[email protected]"
git config --global user.name "Dario Kondratiuk"
git remote add pages https://github.com/kblok/puppeteer-sharp.git
git remote add pages https://github.com/hardkoded/puppeteer-sharp.git
git fetch pages
git checkout master
git subtree add --prefix docs pages/gh-pages
Expand Down
98 changes: 98 additions & 0 deletions lib/PuppeteerSharp.Tests/QuerySelectorTests/PierceHandlerTests.cs
Original file line number Diff line number Diff line change
@@ -0,0 +1,98 @@
using System;
using System.Linq;
using System.Threading.Tasks;
using System.Xml.Linq;
using PuppeteerSharp.Tests.Attributes;
using PuppeteerSharp.Xunit;
using Xunit;
using Xunit.Abstractions;
using static System.Net.Mime.MediaTypeNames;

namespace PuppeteerSharp.Tests.QuerySelectorTests
{
[Collection(TestConstants.TestFixtureCollectionName)]
public class PierceHandlerTests : PuppeteerPageBaseTest
{
public PierceHandlerTests(ITestOutputHelper output) : base(output)
{
}

public override async Task InitializeAsync()
{
await base.InitializeAsync();

await Page.SetContentAsync(@"
<script>
const div = document.createElement('div');
const shadowRoot = div.attachShadow({mode: 'open'});
const div1 = document.createElement('div');
div1.textContent = 'Hello';
div1.className = 'foo';
const div2 = document.createElement('div');
div2.textContent = 'World';
div2.className = 'foo';
shadowRoot.appendChild(div1);
shadowRoot.appendChild(div2);
document.documentElement.appendChild(div);
</script>
");
}
public override Task DisposeAsync()
{
Browser.ClearCustomQueryHandlers();
return base.DisposeAsync();
}

[PuppeteerTest("queryselector.spec.ts", "pierceHandler", "should find first element in shadow")]
[PuppeteerFact]
public async Task ShouldFindFirstElementInShadow()
{
var div = await Page.QuerySelectorAsync("pierce/.foo");
var text = await div.EvaluateFunctionAsync<string>(@"(element) => {
return element.textContent;
}");
Assert.Equal("Hello", text);
}

[PuppeteerTest("queryselector.spec.ts", "pierceHandler", "should find all elements in shadow")]
[PuppeteerFact]
public async Task ShouldFindAllElementsInShadow()
{
var divs = await Page.QuerySelectorAllAsync("pierce/.foo");
var text = await Task.WhenAll(
divs.Select(div => {
return div.EvaluateFunctionAsync<string>(@"(element) => {
return element.textContent;
}");
}));
Assert.Equal("Hello World", string.Join(" ", text));
}

[PuppeteerTest("queryselector.spec.ts", "pierceHandler", "should find first child element")]
[PuppeteerFact]
public async Task ShouldFindFirstChildElement()
{
var parentElement = await Page.QuerySelectorAsync("html > div");
var childElement = await parentElement.QuerySelectorAsync("pierce/div");
var text = await childElement.EvaluateFunctionAsync<string>(@"(element) => {
return element.textContent;
}");
Assert.Equal("Hello", text);
}

[PuppeteerTest("queryselector.spec.ts", "pierceHandler", "should find all child elements")]
[PuppeteerFact]
public async Task ShouldFindAllChildElements()
{
var parentElement = await Page.QuerySelectorAsync("html > div");
var childElements = await parentElement.QuerySelectorAllAsync("pierce/div");
var text = await Task.WhenAll(
childElements.Select(div => {
return div.EvaluateFunctionAsync<string>(@"(element) => {
return element.textContent;
}");
}));
Assert.Equal("Hello World", string.Join(" ", text));
}
}
}
65 changes: 64 additions & 1 deletion lib/PuppeteerSharp/CustomQueriesManager.cs
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
using System;
using System.Collections;
using System.Collections.Generic;
using System.Linq;
using System.Text.RegularExpressions;
Expand All @@ -8,7 +9,58 @@ namespace PuppeteerSharp
internal class CustomQueriesManager
{
private readonly Dictionary<string, InternalQueryHandler> _queryHandlers = new();
private readonly Dictionary<string, InternalQueryHandler> _builtInHandlers = new();
private readonly InternalQueryHandler _pierceHandler = MakeQueryHandler(new CustomQueryHandler
{
QueryOne = @"(element, selector) => {
let found = null;
const search = (root) => {
const iter = document.createTreeWalker(root, NodeFilter.SHOW_ELEMENT);
do {
const currentNode = iter.currentNode;
if (currentNode.shadowRoot) {
search(currentNode.shadowRoot);
}
if (currentNode instanceof ShadowRoot) {
continue;
}
if (currentNode !== root && !found && currentNode.matches(selector)) {
found = currentNode;
}
} while (!found && iter.nextNode());
};
if (element instanceof Document) {
element = element.documentElement;
}
search(element);
return found;
}",
QueryAll = @"(element, selector) => {
const result = [];
const collect = (root) => {
const iter = document.createTreeWalker(root, NodeFilter.SHOW_ELEMENT);
do {
const currentNode = iter.currentNode;
if (currentNode.shadowRoot) {
collect(currentNode.shadowRoot);
}
if (currentNode instanceof ShadowRoot) {
continue;
}
if (currentNode !== root && currentNode.matches(selector)) {
result.push(currentNode);
}
} while (iter.nextNode());
};
if (element instanceof Document) {
element = element.documentElement;
}
collect(element);
return result;
}",
});

private readonly Dictionary<string, InternalQueryHandler> _builtInHandlers;

private readonly Regex _customQueryHandlerNameRegex = new("[a-zA-Z]+$", RegexOptions.Compiled);
private readonly Regex _customQueryHandlerParserRegex = new("(?<query>^[a-zA-Z]+)\\/(?<selector>.*)", RegexOptions.Compiled);
private readonly InternalQueryHandler _defaultHandler = MakeQueryHandler(new CustomQueryHandler
Expand All @@ -17,6 +69,17 @@ internal class CustomQueriesManager
QueryAll = "(element, selector) => element.querySelectorAll(selector)",
});

public CustomQueriesManager()
{
_builtInHandlers = new()
{
["pierce"] = _pierceHandler,
};
_queryHandlers = _builtInHandlers.ToDictionary(
entry => entry.Key,
entry => entry.Value);
}

internal void RegisterCustomQueryHandler(string name, CustomQueryHandler queryHandler)
{
if (_queryHandlers.ContainsKey(name))
Expand Down

0 comments on commit faec0b1

Please sign in to comment.