Add meaningful Win32 socket error code to cnex #446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gitlarryf
force-pushed
the
win32-socket-code
branch
from
51cc5c4 to
caa23a5
Compare
ghewgill
requested changes
Feb 16, 2024
exec/cnex/lib/net.c
Outdated
| @@ -58,6 +58,25 @@ static SOCKET *check_socket(TExecutor *exec, Object *o) | |||
| return o->ptr; | |||
| } | |||
|
|
|||
| static char *socket_error_message(int err) | |||
There was a problem hiding this comment.
This should return const char instead of char
There was a problem hiding this comment.
That's what was intended. I missed that. It's been fixed and pushed.
ghewgill
force-pushed
the
main
branch
4 times, most recently
from
d299f4d to
43de4ec
Compare
gitlarryf
force-pushed
the
win32-socket-code
branch
from
caa23a5 to
da6d7b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.