Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix show chatwindow #13

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ Either follow the original documentation by Google: https://developer.chrome.com
or you can use the `build-and-package.sh` to pack the exension

- First get the private key for Duke. Save it to some file i.e. `/Users/myname/key.pem`
- Bump version in manifest.json
- Bump version like in this commit https://github.com/giosg/duke/commit/0cc73a9f333a57b52ced95900a43c8cefb63af25
- Build `duke.zip` with `build-and-package.sh`
- Example usage `./build-and-package.sh --key=/Users/myname/key.pem`
- The script should output `duke.zip` and you can upload that to Chrome Webstore
Expand Down
9 changes: 7 additions & 2 deletions app/scripts/postmessagelistener.js
Original file line number Diff line number Diff line change
Expand Up @@ -159,8 +159,13 @@
};

DukePostMessageClient.prototype.on_showClient = function(data) {
GiosgClient.createChatDialog();
GiosgClient.showClient();
if (GiosgClient.isOperatorOnline === true) {
GiosgClient.showClient();
GiosgClient.createChatDialog();
} else {
var room = giosg.rooms[0];
GiosgClient.showClient(false, room);
}
this.sendResponse(data.query, {});
};

Expand Down